Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dependency declaration to che-deps repo #6606

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Move dependency declaration to che-deps repo #6606

merged 1 commit into from
Oct 6, 2017

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Move dependency declaration to che-deps repo
related to eclipse-che/che-dependencies#57

What issues does this PR fix or reference?

#5362

n/a

Release Notes

n/a

Docs PR

n/a

@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 6, 2017
@skabashnyuk skabashnyuk requested a review from riuvshin October 6, 2017 06:49
@skabashnyuk skabashnyuk requested a review from vparfonov as a code owner October 6, 2017 06:49
@sleshchenko
Copy link
Member

Should not we move jsr305 dependency also somewhere like che-dependencies project, as it is not eclipse che artifact?

@codenvy-ci
Copy link

Build # 4028 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4028/ to view the results.

@skabashnyuk
Copy link
Contributor Author

@sleshchenko we could but we don't want to. It's here because it's needed for gwt compilation. But we don't want to give developers signal to use it in compile scope mode because it's declared as build only.

@benoitf benoitf added the target/branch Indicates that a PR will be merged into a branch other than master. label Oct 6, 2017
@sleshchenko
Copy link
Member

@skabashnyuk Thanks for explanation

@skabashnyuk skabashnyuk merged commit a399d32 into che-multiuser Oct 6, 2017
@skabashnyuk skabashnyuk deleted the che-multiuser-new-deps branch October 6, 2017 08:33
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riuvshin riuvshin riuvshin approved these changes

@vparfonov vparfonov vparfonov approved these changes

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skabashnyuk @sleshchenko @codenvy-ci @vparfonov @riuvshin @benoitf