Create .ssh if it does not exist #7062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
benoitf
added
the
status/code-review
|
Can one of the admins verify this patch? |
Signed-off-by: David Windell <david@outeredgeuk.com>
davidwindell
force-pushed
the
patch-4
branch
2 times, most recently
from
1bf0f56 to
fd4b657
Compare
davidwindell
changed the title
benoitf
added
the
kind/bug
tolusha
reviewed
Oct 30, 2017
| @@ -34,7 +36,7 @@ echo 'api_url='"$api_url" >> ${SCRIPT_FILE} | |||
| echo 'request="'${request}'"' >> ${SCRIPT_FILE} | |||
| # Ssh key request may return key with decoded '=' symbol, so need to replace '\u003d' to '='. | |||
| # TODO remove the replacement after https://github.com/eclipse/che/issues/5253 will be fixed. | |||
| echo 'ssh_key=$(${request} "$api_url/ssh/vcs/find?name=$host$(if [ -n "$token" ]; then echo "&token=$token"; fi)"| grep -Po '\''"privateKey":.*?[^\\\\]",'\''| sed -e "s/\"privateKey\":\"//" | sed -e "s/\\\\\u003d/=/g")' >> ${SCRIPT_FILE} | |||
| echo 'ssh_key=$(${request} "$api_url/ssh/vcs/find?name=$host$(if [ -n "$token" ]; then echo "&token=$token"; fi)"| grep -Po '\''"privateKey":.*?[^\\\\]",'\''| sed -e "s/\"privateKey\":\"//" | sed -e "s/\",//" | sed -e "s/\\\\\u003d/=/g")' >> ${SCRIPT_FILE} | |||
There was a problem hiding this comment.
@tolusha I couldn't reproduce the error we were having last week anymore so I've just made the PR fix the missing ssh dir for now.
davidwindell
changed the title
benoitf
approved these changes
Oct 30, 2017
tolusha
approved these changes
Oct 30, 2017
garagatyi
approved these changes
Oct 30, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git credentials agent will fail if the base image used doesn't already have an
.sshfolder for the user. This PR will create one if it doesn't exist.