Refactor remaining everrest websocket endpoints to use Json RPC #8388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
benoitf,
garagatyi,
riuvshin,
skabashnyuk and
vparfonov
as code owners
benoitf
added
status/code-review
benoitf
reviewed
Jan 22, 2018
| @@ -15,7 +15,7 @@ import {Websocket} from "../../../spi/websocket/websocket"; | |||
| import {HttpJsonRequest} from "../../../spi/http/default-http-json-request"; | |||
| import {DefaultHttpJsonRequest} from "../../../spi/http/default-http-json-request"; | |||
| import {HttpJsonResponse} from "../../../spi/http/default-http-json-request"; | |||
| import {MessageBus} from "../../../spi/websocket/messagebus"; | |||
| import {JsonRpcBus} from "../../../spi/websocket/json-rpc-bus"; | |||
There was a problem hiding this comment.
now, we can get rid of MessageBus class as well and all references to it.
benoitf
reviewed
Jan 22, 2018
| @@ -113,6 +113,8 @@ export class System { | |||
| }); | |||
| return messageBus.subscribeAsync(channelToListen, callbackSubscriber); | |||
| }).then((subscribed: string) => { | |||
| return this.delay(2000); | |||
There was a problem hiding this comment.
please add a comment why it's required
benoitf
approved these changes
Jan 22, 2018
skabashnyuk
approved these changes
Jan 22, 2018
riuvshin
approved these changes
Jan 22, 2018
garagatyi
reviewed
Jan 23, 2018
| @@ -22,7 +21,5 @@ | |||
| @DynaModule | |||
| public class WsAgentServletModule extends ServletModule { | |||
garagatyi
approved these changes
Jan 23, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors organization & system websocket channels to use Json RPC. Refactor CLI client in part of graceful shutdown. Remove utility classes used for everrest websockets.
What issues does this PR fix or reference?
#5357
Release Notes
Refactored organization & system websocket channels to use Json RPC
Docs PR
N/A