Provide configuration property to be able to set docker image build timeout #9259
Conversation
akorneta
added
kind/enhancement
| @@ -1341,6 +1332,34 @@ public void shouldThrowIOExceptionWhenBuildImageButNoSuccessMessageInResponse() | |||
| verify(dockerResponse).getInputStream(); | |||
| } | |||
|
|
|||
| @Test( | |||
| expectedExceptions = DockerException.class, | |||
| expectedExceptionsMessageRegExp = "Docker image build exceed timeout.*" | |||
There was a problem hiding this comment.
Would it better to rewrite it in the following way "Docker image build exceed timeout .* seconds." ?
| @@ -900,7 +907,7 @@ private String buildImage( | |||
| "Docker image build failed. Image id not found in build output.", 500); | |||
| }); | |||
|
|
|||
| return imageIdFuture.get(); | |||
| return imageIdFuture.get(imageBuildTimeoutSec, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
Do we interrupt Thread which builds images? Will be building really interrupted?
There was a problem hiding this comment.
:O good point, @akorneta are you sure that docker build process will be interrupted?
There was a problem hiding this comment.
@sleshchenko Do you know a better approach?
AFAIK from recent versions of Docker, it is a way to perform interruption of the build.
There was a problem hiding this comment.
@garagatyi No, I don't. I just ask if it will solve the original issue 😺
There was a problem hiding this comment.
@sleshchenko , @riuvshin so if you carefully look at the implementation of docker image build you will see that in the case when exceptions occur in main(waiting) thread there no any additional work for interruption of building thread the explanation why is placed here.
| @@ -267,6 +267,9 @@ che.infra.docker.bootstrapper.server_check_period_sec=3 | |||
| # in parallel on workspace startups. | |||
| che.infra.docker.max_pull_threads=10 | |||
|
|
|||
| # Time(in seconds) that limits the docker build process. | |||
| # The default value is 8 minutes, after which the build will be considered as failed. | |||
| che.infra.docker.build_timeout_sec=480 | |||
There was a problem hiding this comment.
How much time does it take to build dockerfile of Che master in some good case?
There was a problem hiding this comment.
in master, we do not have any stacks that contain workspace config with dockerfile recipe type but form my custom workspace config docker image build does not take more than 3 minutes. The build process depends on many factors so it is hard to estimate the default value, any suggestions are welcome.
| @@ -900,7 +907,7 @@ private String buildImage( | |||
| "Docker image build failed. Image id not found in build output.", 500); | |||
| }); | |||
|
|
|||
| return imageIdFuture.get(); | |||
| return imageIdFuture.get(imageBuildTimeoutSec, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
Can we add an ability to disable timeout? It might be useful for some users.
akorneta
force-pushed
the
docker-build-timeout
branch
2 times, most recently
from
e661f7e
to
18382b1
Compare
|
ci-test |
|
ci-test build report: |
|
ci-test |
akorneta
force-pushed
the
docker-build-timeout
branch
from
18382b1
to
d28aa67
Compare
|
ci-test build report: |
akorneta
force-pushed
the
docker-build-timeout
branch
from
d28aa67
to
dcabc47
Compare
akorneta
force-pushed
the
docker-build-timeout
branch
from
dcabc47
to
6c813ef
Compare
akorneta
removed
the
status/code-review
What does this PR do?
Provides configuration property which allows setting a limitation for docker image build timeout.
property:
che.infra.docker.build_timeout_secdefault value(experimental):
480 secondsWhat issues does this PR fix or reference?
#9130