Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added starting servers checkers after recovering only for RUNNING workspaces #9492

Merged
merged 2 commits into from
Apr 19, 2018

Conversation

sleshchenko
Copy link
Member

What does this PR do?

Added starting servers checkers after recovering only for RUNNING workspaces.
Also, it contains separated commit with fixing Transactions and NPE issues in K8s runtimes caches.

What issues does this PR fix or reference?

Partially fixes #9453

Release Notes

N/A

Docs PR

N/A

@sleshchenko sleshchenko requested a review from garagatyi as a code owner April 19, 2018 08:24
@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Apr 19, 2018
entityManager.find(KubernetesRuntimeState.class, new RuntimeId(identity));
entityManager.find(KubernetesRuntimeState.class, new RuntimeId(id));

Optional<KubernetesRuntimeState> runtimeStateOpt = get(id);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one of the runtimes is odd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed.

Copy link

@garagatyi garagatyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@garagatyi garagatyi merged commit 1ab0ca7 into eclipse-che:master Apr 19, 2018
@garagatyi garagatyi deleted the k8sServerCheckers branch April 19, 2018 09:45
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 19, 2018
@benoitf benoitf added this to the 6.5.0 milestone Apr 19, 2018
@sleshchenko sleshchenko self-assigned this Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server checkers works incorrectly when s8k/os workspaces are recovered
4 participants