Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Move refactoring #9953

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Support Move refactoring #9953

merged 1 commit into from
Jun 15, 2018

Conversation

svor
Copy link
Contributor

@svor svor commented Jun 6, 2018 •
edited
Loading

Signed-off-by: Valeriy Svydenko vsvydenk@redhat.com

What does this PR do?

Make it possible to do Move operation by using jdt.ls.
The result of this PR is here: https://www.youtube.com/watch?v=LEy_IRUKKgo

Depends on

What issues does this PR fix or reference?

#6748

@svor svor added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Jun 6, 2018
@svor svor self-assigned this Jun 6, 2018
@svor svor requested review from tolusha and tsmaeder June 6, 2018 11:51
@svor svor requested review from dkulieshov and evidolob as code owners June 6, 2018 11:51
@benoitf benoitf added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jun 6, 2018
@svor svor mentioned this pull request Jun 6, 2018
Closed
tsmaeder
tsmaeder approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For once, I have nothing to complain about :-)

@svor svor requested a review from vparfonov as a code owner June 13, 2018 09:44
@tsmaeder tsmaeder force-pushed the move branch 3 times, most recently from 729419f to 060c668 Compare June 13, 2018 14:12
@svor
use jdt.ls to support Move refactoring
11e57b4 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor svor merged commit d2bfabc into 5730_java_ls_poc Jun 15, 2018
@svor svor deleted the move branch June 15, 2018 08:51
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 15, 2018
tsmaeder pushed a commit that referenced this pull request Jun 26, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
f86662d 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Jul 13, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
1a6c3e0 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Jul 27, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
a3d0ae4 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tolusha pushed a commit that referenced this pull request Aug 7, 2018
@tolusha
Use jdt.ls to support Move refactoring (#9953)
0d7186c 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Aug 22, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
d22b9d1 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Aug 29, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
4b7b5d7 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tolusha pushed a commit that referenced this pull request Sep 5, 2018
@tolusha
Use jdt.ls to support Move refactoring (#9953)
391d609 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Sep 13, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
7512bbe 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Sep 20, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
1b48858 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Sep 26, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
d216980 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 1, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
8106899 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 5, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
c924612 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 12, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
e88be46 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 16, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
2fa7c0c 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
afccbaf 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
@tsmaeder
Use jdt.ls to support Move refactoring (#9953)
68ae927 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
@svor @tsmaeder
Use jdt.ls to support Move refactoring (#9953)
b408073 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
@svor @tsmaeder
Use jdt.ls to support Move refactoring (#9953)
eb56f6f 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
@svor @tsmaeder
Use jdt.ls to support Move refactoring (#9953)
4bfac62 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmaeder tsmaeder tsmaeder approved these changes

@tolusha tolusha Awaiting requested review from tolusha

@dkulieshov dkulieshov Awaiting requested review from dkulieshov

@evidolob evidolob Awaiting requested review from evidolob

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@svor svor

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svor @tsmaeder @benoitf