Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for DACO-CONTROL statement in DaCo dialect #2201

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat: Add support for DACO-CONTROL statement in DaCo dialect #2201

merged 1 commit into from
Jan 15, 2024

Conversation

juleskreutzer
Copy link

This PR will add support for the DACO-CONTROL statement in the DaCo dialect used at DAF Trucks.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Usecase: TestDaCoControlSection.java

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation - N/A
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ap891843 ap891843 requested a review from ishche January 15, 2024 12:19
@ishche ishche requested a review from ap891843 January 15, 2024 13:38
Copy link
Contributor

@ap891843 ap891843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ishche
Copy link
Contributor

ishche commented Jan 15, 2024

Looks good. Thank you!

@ishche ishche merged commit 8dfd7e0 into eclipse-che4z:development Jan 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants