Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE575629 - Most program has errors in SQL-ERROR-RTN paragraph #2210

Conversation

ilidio-lopes
Copy link
Contributor

@ilidio-lopes ilidio-lopes commented Jan 23, 2024

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

return foundVariable;
}
outer:
for (VariableNode variableNode : definedVariables.values()) {
Copy link
Contributor

@ap891843 ap891843 Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could have used stream API

definedVariables.values()
            .stream().flatMap(Node::getDepthFirstStream)
            .filter(VariableNode.class::isInstance)
            .map(VariableNode.class::cast)
            .filter(var -> var.getName().equals(name))
            .findFirst(); // or .collect(Collectors.toList())

Copy link
Contributor

@ap891843 ap891843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add a UseCase test for this

@ishche
Copy link
Contributor

ishche commented Feb 21, 2024

Please update the PR description and squash commits.

@ilidio-lopes
Copy link
Contributor Author

Please update the PR description and squash commits.

I cannot squash. Probably because I don't have write permission.

@ilidio-lopes ilidio-lopes force-pushed the DE575629-Most_program_has_errors_in_SQL-ERROR-RTN_paragraph branch from 355a689 to 216cbf9 Compare February 21, 2024 12:15
Copy link
Contributor

@ap891843 ap891843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ap891843 ap891843 merged commit 79f40b3 into eclipse-che4z:development Feb 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants