Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/allowed identifier #2309

Merged
merged 3 commits into from
May 28, 2024

Conversation

ap891843
Copy link
Contributor

@ap891843 ap891843 commented May 24, 2024

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test following Cobol keywords are not allowed as identifiers
    address bottom close count currency data date day dbcs exit extend first initial national object off quote separate sequence service standard suppress terminal test time top

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@@ -38,7 +37,7 @@ class VariableCompletionTest {

private static final String HEADER =
" Identification Division.\n"
+ " Program-id. TEST.\n"
Copy link
Contributor Author

@ap891843 ap891843 May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cobol keywords are not allowed. Check below sysprint snapshot

` LineID PL SL ----+-*A-1-B--+----2----+----3----+----4----+----5----+----6----+----7-|--+----8 Map and Cross Reference
0 000001 IDENTIFICATION DIVISION.
000002 PROGRAM-ID. TEST.

==000002==> IGYDS1090-E Expected a program-name, but found "TEST". This program was given the
name "CBLNAM01".

==000002==> IGYDS1089-S "TEST" was invalid. Scanning was resumed at the next area "A" item,
level-number, or the start of the next clause.`

@ap891843
Copy link
Contributor Author

commit ba78fa1 holds all the adjustments to the test

@ap891843 ap891843 marked this pull request as ready for review May 24, 2024 12:48
@ap891843 ap891843 requested review from ishche and Nurkambay May 24, 2024 12:49
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@ap891843 ap891843 merged commit 20ef22e into eclipse-che4z:development May 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants