Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rowid variable arrays #2401

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Rowid variable arrays #2401

merged 1 commit into from
Jul 25, 2024

Conversation

ilidio-lopes
Copy link
Contributor

@ilidio-lopes ilidio-lopes commented Jul 24, 2024 •
edited
Loading

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Check the test cases in the PR . Host variables can be in a sample code
        Identification Division.
        Program-Id. 'TEST1'.
        Data Division.
        Working-Storage Section.
       01 GREET. 
           02 VAR1 USAGE IS SQL TYPE IS ROWID OCCURS 10000 TIMES.
        PROCEDURE division.
           display  VAR1(1).

image

  • Autocomplete

image

  • Test A
  • Test B

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

ap891843
ap891843 reviewed Jul 24, 2024
View reviewed changes
server/engine/src/main/antlr4/org/eclipse/lsp/db2/parser/Db2SqlParser.g4 Outdated
@@ -64,6 +68,10 @@ xml_lobNO_size: BLOB_FILE | CLOB_FILE | DBCLOB_FILE;

xml_as: XML AS;

rowid: ROWID;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could use ROWID directly at rowid_host_variables_arrays, instead of creating a rule for it

ap891843
ap891843 reviewed Jul 24, 2024
View reviewed changes
server/engine/src/main/antlr4/org/eclipse/lsp/db2/parser/Db2SqlLexer.g4 Outdated
@@ -492,6 +492,7 @@ NULTERM : N U L T E R M;
NUMBER : N U M B E R;
NUMERIC : N U M E R I C;
NUMPARTS: N U M P A R T S;
OCCURS : O C C U R S;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check auto completion and coloring for these added lexemes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added by #2394

@ilidio-lopes ilidio-lopes force-pushed the US966888-ROWID_variable_arrays branch from 0e1cc73 to c75a0f6 Compare July 24, 2024 09:10
@ilidio-lopes ilidio-lopes force-pushed the US966888-ROWID_variable_arrays branch 2 times, most recently from c3f23aa to 7afc98e Compare July 25, 2024 08:27
@ilidio-lopes ilidio-lopes force-pushed the US966888-ROWID_variable_arrays branch from 7afc98e to 92ae9a8 Compare July 25, 2024 12:31
@ilidio-lopes ilidio-lopes force-pushed the US966888-ROWID_variable_arrays branch from 92ae9a8 to 816a1e7 Compare July 25, 2024 13:51
@ap891843 ap891843 merged commit 555df2a into eclipse-che4z:development Jul 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavek-kucera slavek-kucera slavek-kucera approved these changes

@ap891843 ap891843 ap891843 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilidio-lopes @slavek-kucera @ap891843