Fix CICS Allocate #2454
Fix CICS Allocate #2454
Conversation
|
@slavek-kucera when you get a chance |
| cics_allocate_appc_mro_lut61_sysid: SYSID cics_data_area (PROFILE cics_name | NOQUEUE | STATE cics_cvda | cics_handle_response)*; | ||
| cics_allocate_lut61_session: SESSION cics_name (PROFILE cics_name | NOQUEUE | cics_handle_response)*; | ||
| cics_allocate_appc_partner: PARTNER cics_name (NOQUEUE | STATE cics_cvda | cics_handle_response)*; |
There was a problem hiding this comment.
the preprocessor seems to tolerate reordering the SYSID, SESSION and PARTNER keywords.
There was a problem hiding this comment.
I am aware, this is a good topic for design discussion. This ordering is under the assumption that the user would start these commands off with at least the target sub command option - it seems unusual not to. However it does not make us fully flexible but does clean up our routing efficiency through the antlr parser. Am happy to revert to the (...)+ style if we want this to be FULLY flexible to chunk the target subcommand anywhere in the body.
There was a problem hiding this comment.
This would also bring up the argument to question if we should pull in the main command to these i.e:
(ALLOCATE | SYSID ...)+
There was a problem hiding this comment.
ALLOCATE is required to be before the other arguments, however those could be all part of the same (...)+ rule, verified in the visitor.
| private static final String APPC_ALL_OPTIONS_VALID_ONE = | ||
| ALLOCATE + PARTNER + NOQUEUE + STATE.trim(); | ||
|
|
||
| private static final String APPC_ALL_OPTIONS_VALID_TWO = | ||
| ALLOCATE + SYSID + PROFILE + NOQUEUE + STATE.trim(); | ||
|
|
||
| private static final String APPC_INVALID_ONE = | ||
| ALLOCATE + PARTNER + "{PROFILE|error1}(100) " + NOQUEUE + "STATE(err)"; | ||
|
|
||
| private static final String LUT61_ALL_OPTIONS_VALID_ONE = | ||
| ALLOCATE + SESSION + PROFILE + NOQUEUE.trim(); | ||
|
|
||
| private static final String LUT61_INVALID_ONE = | ||
| ALLOCATE + "SESSION(100) " + "PROFILE(100) " + "{STATE|errorOne}(100)"; | ||
|
|
||
| private static final String MRO_ALL_OPTIONS_VALID_ONE = | ||
| ALLOCATE + SYSID + PROFILE + NOQUEUE + STATE.trim(); | ||
|
|
There was a problem hiding this comment.
These constants are actually making it harder for me to follow the test. I suggest moving the concatenations directly into the test bodies.
There was a problem hiding this comment.
I agree, will update.
chacebot
force-pushed
the
fix-cics-allocate
branch
from
7ad8e25
to
7f5afcb
Compare
chacebot
force-pushed
the
fix-cics-allocate
branch
from
7f5afcb
to
986b993
Compare
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: