Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cics issue #2475

Merged
merged 22 commits into from
Sep 23, 2024
Merged

Fix cics issue #2475

merged 22 commits into from
Sep 23, 2024

Conversation

chacebot
Copy link
Contributor

Removes WAIT from cics_handle_response after testing revealed that the compiler seemingly accepts that option where the documentation specify it and is not as universal as RESP, RESP2, or NOHANDLE.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TestCicsIssue.java
  • Test against COBOL compiler

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@chacebot
Copy link
Contributor Author

@slavek-kucera

@chacebot chacebot marked this pull request as draft September 18, 2024 12:59
@chacebot
update: fix cics allocate
0603c76
@chacebot
update: revert allocate antlr parser rule because it works
be0752f
@chacebot
chore: removed commented out lines
1b55968
@chacebot
update: added order flexibility to sub command and removed string con…
57db777 
…cats
@chacebot
update: corrected antlr parser rules for new approach
8b76367
@chacebot
update: started parser rule context checks
1fbe548
@chacebot
update: added checking for issue add
c94eb4f
@chacebot
update: add context
99ba0d8
@chacebot
update: added more rule context checking
69d3b71
@chacebot
update: added check for end option
fcf333b
@chacebot
update: added context rule logic for issue, removed wait from respons…
6570407 
…e handler after testing
@chacebot
update: refactored cics issue to use new rule checks
2b749ef
@chacebot
chore: remove typo add documentation and consolidate a logic flow path
b425a12
@chacebot
chore: removed unused import
9b66a5f
@chacebot
update: created sub rule for common options
862535c
@chacebot
fix: error message in test
aae1db0
@chacebot
update: refactor ISSUE context parsing to use mutualllyExclusive helper
e75a313
@chacebot chacebot marked this pull request as ready for review September 19, 2024 18:50
slavek-kucera
slavek-kucera approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@slavek-kucera slavek-kucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few expressions can be simplified, otherview looks good.

...n/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSIssueOptionsCheckUtility.java Outdated Show resolved Hide resolved
...n/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSIssueOptionsCheckUtility.java Outdated Show resolved Hide resolved
...n/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSIssueOptionsCheckUtility.java Outdated Show resolved Hide resolved
@ishche ishche merged commit 090cf00 into eclipse-che4z:development Sep 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavek-kucera slavek-kucera slavek-kucera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chacebot @slavek-kucera @ishche