Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix snippet text for sections and paragraphs #2533

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix: Fix snippet text for sections and paragraphs #2533

merged 2 commits into from
Oct 9, 2024

Conversation

Nurkambay
Copy link
Contributor

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

slavek-kucera
slavek-kucera reviewed Oct 9, 2024
View reviewed changes
server/engine/src/main/java/org/eclipse/lsp/cobol/core/visitor/CobolVisitor.java
lastParagraphNode.getLocality().getRange().setEnd(lastSentensePosition);
lastParagraphNode.setText(extendedDocument.getBaseText(lastParagraphNode.getLocality()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to delay this action to the point where it is actually requrested?
And perhaps consider the needs of the only user of this data CFASTBuilderImpl.cutSnippet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but in that case we need to pass document text to ProcessingResult to satisfy CliCFAST.
Maybe it is okay

@Nurkambay Nurkambay requested a review from ishche October 9, 2024 12:21
ishche
ishche approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@ishche ishche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Nurkambay Nurkambay merged commit 39b0337 into eclipse-che4z:development Oct 9, 2024
18 checks passed
@Nurkambay Nurkambay deleted the fix-snippet branch October 9, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishche ishche ishche approved these changes

@slavek-kucera slavek-kucera slavek-kucera approved these changes

@ap891843 ap891843 Awaiting requested review from ap891843

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nurkambay @ishche @slavek-kucera