Cics READ improvements #2576
Open
Cics READ improvements #2576
+195
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving to draft. Is reliant upon functions from the WEB fix PR #2469. (Was developed and tested off of that branch before moving to its own one.) |
mm-broadcom
force-pushed
the
CICS-READ-Improvements
branch
from
9fd507b to
4093cb2
Compare
Added support for the obsolete DATASET keyword. When both are used, inform the user to use FILE instead of DATASET. (They are synonymous to one another, but FILE is the one to use going forward.)
|
@KutluOzel-b Could you review this? |
KutluOzel-b
suggested changes
Nov 27, 2024
server/engine/src/main/antlr4/org/eclipse/lsp/cobol/implicitDialects/cics/CICSParser.g4
Show resolved
Hide resolved
server/engine/src/main/antlr4/org/eclipse/lsp/cobol/implicitDialects/cics/CICSParser.g4
Outdated
Show resolved
Hide resolved
server/engine/src/main/antlr4/org/eclipse/lsp/cobol/implicitDialects/cics/CICSParser.g4
Show resolved
Hide resolved
...in/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSReadOptionsCheckUtility.java
Outdated
Show resolved
Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsReadStatement.java
Outdated
Show resolved
Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsReadStatement.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSReadOptionsCheckUtility.java
Outdated
Show resolved
Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsReadStatement.java
Outdated
Show resolved
Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsReadStatement.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSReadOptionsCheckUtility.java
Outdated
Show resolved
Hide resolved
KutluOzel-b
reviewed
Nov 28, 2024
...in/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSReadOptionsCheckUtility.java
Show resolved
Hide resolved
chacebot
reviewed
Dec 17, 2024
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsReadStatement.java
Show resolved
Hide resolved
...in/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSReadOptionsCheckUtility.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
Wrote some tests for the fullest and minimal extent allowed for READ along with invalid test case(s).
Checklist: