Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cics PUT CONTAINER improvements #2598

Open
wants to merge 21 commits into
base: development
Choose a base branch
from
Open

Cics PUT CONTAINER improvements #2598

wants to merge 21 commits into from
+184 −11

Conversation

mm-broadcom
Copy link
Contributor

How Has This Been Tested?

Created both valid and invalid instances and added tests verifying as such.

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@mm-broadcom
Copy link
Contributor Author

@KutluOzel-b Could you review this?

KutluOzel-b
KutluOzel-b suggested changes Nov 29, 2024
View reviewed changes
...org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSPutContainerOptionsCheckUtility.java Show resolved Hide resolved
...org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSPutContainerOptionsCheckUtility.java Show resolved Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsPutContainerStatement.java Outdated Show resolved Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsPutContainerStatement.java Outdated Show resolved Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsPutContainerStatement.java Outdated Show resolved Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsPutContainerStatement.java Outdated Show resolved Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsPutContainerStatement.java Show resolved Hide resolved
mm-broadcom and others added 6 commits December 2, 2024 08:41
@mm-broadcom @KutluOzel-b
Update server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/Tes…
b5a685c 
…tCicsPutContainerStatement.java

Co-authored-by: Kutlu <104970275+KutluOzel-b@users.noreply.github.com>
@mm-broadcom @KutluOzel-b
Update server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/Tes…
27eea7a 
…tCicsPutContainerStatement.java

Co-authored-by: Kutlu <104970275+KutluOzel-b@users.noreply.github.com>
@mm-broadcom @KutluOzel-b
Update server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/Tes…
f6c67b2 
…tCicsPutContainerStatement.java

Co-authored-by: Kutlu <104970275+KutluOzel-b@users.noreply.github.com>
@mm-broadcom @KutluOzel-b
Update server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/Tes…
078c28a 
…tCicsPutContainerStatement.java

Co-authored-by: Kutlu <104970275+KutluOzel-b@users.noreply.github.com>
@mm-broadcom
Add FROM check, test, fix imports
9e71158
@mm-broadcom
Merge branch 'development' into CICS-PUT-CONTAINER-Improvements
b0fdcab
KutluOzel-b
KutluOzel-b approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@KutluOzel-b KutluOzel-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ap891843
ap891843 reviewed Dec 17, 2024
View reviewed changes
...c/main/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSOptionsCheckUtility.java Outdated
@@ -147,6 +150,9 @@ public CICSOptionsCheckUtility(DialectProcessingContext context, List<SyntaxErro
optionsMap.put(
CICSWriteOptionsCheckUtility.RULE_INDEX,
new CICSWriteOptionsCheckUtility(context, errors));
optionsMap.put(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks unrelated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate.

@ap891843
Copy link
Contributor

LGTM! waiting for the merge conflicts to be resolved

slavek-kucera
slavek-kucera reviewed Jan 2, 2025
View reviewed changes
...c/main/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSOptionsCheckUtility.java
@@ -157,17 +160,14 @@ public CICSOptionsCheckUtility(DialectProcessingContext context, List<SyntaxErro
CICSEnqOptionsCheckUtility.RULE_INDEX,
new CICSEnqOptionsCheckUtility(context, errors));
optionsMap.put(
CICSWriteOptionsCheckUtility.RULE_INDEX,
new CICSWriteOptionsCheckUtility(context, errors));
CICSWSAEPRUtility.RULE_INDEX,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CICSWriteOptionsCheckUtility was removed from the list in the last commit.

...org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSPutContainerOptionsCheckUtility.java
private static final Map<Integer, ErrorSeverity> DUPLICATE_CHECK_OPTIONS =
new HashMap<Integer, ErrorSeverity>() {
{
put(CICSLexer.PUT, ErrorSeverity.ERROR);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PUT is not an operand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KutluOzel-b KutluOzel-b KutluOzel-b approved these changes

@ap891843 ap891843 ap891843 left review comments

@slavek-kucera slavek-kucera slavek-kucera left review comments

@chacebot chacebot chacebot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mm-broadcom @ap891843 @chacebot @slavek-kucera @KutluOzel-b