Cics REQUEST improvements #2602
Open
+177
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KutluOzel-b Could you review this? |
KutluOzel-b
suggested changes
Nov 29, 2024
server/engine/src/main/antlr4/org/eclipse/lsp/cobol/implicitDialects/cics/CICSParser.g4
Show resolved
Hide resolved
server/engine/src/main/antlr4/org/eclipse/lsp/cobol/implicitDialects/cics/CICSParser.g4
Show resolved
Hide resolved
server/engine/src/main/antlr4/org/eclipse/lsp/cobol/implicitDialects/cics/CICSParser.g4
Show resolved
Hide resolved
| checkDuplicates(ctx); | ||
| } | ||
|
|
||
| private void checkEncryptptkt(CICSParser.Cics_request_encryptptktContext ctx) { |
There was a problem hiding this comment.
add check for ENCRYPTPTKT mandatory
| } | ||
|
|
||
| private void checkPassticket(CICSParser.Cics_request_passticketContext ctx) { | ||
| checkHasMandatoryOptions(ctx.ESMAPPNAME(), ctx, "ESMAPPNAME"); |
There was a problem hiding this comment.
add check for PASSTICKET mandatory
| CICSTestUtils.noErrorTest(PASSTICKET_VALID_2); | ||
| } | ||
|
|
||
| // Invalid Tests |
There was a problem hiding this comment.
Add tests for PASSTICKET and ENCRYPTPTKT is being mandatory
There was a problem hiding this comment.
Doesn't work that way. There is no guarantee that you'd be in the rule the user intended.
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsRequestStatement.java
Outdated
Show resolved
Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsRequestStatement.java
Show resolved
Hide resolved
…tCicsRequestStatement.java Co-authored-by: Kutlu <104970275+KutluOzel-b@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
Created and ran tests for both valid and invalid REQUEST commands.
Checklist: