Cics ROUTE improvements #2626
Open
Cics ROUTE improvements #2626
+185
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checks for grammar, tied to optionsMap, added support function where one or more rules must be present.
chacebot
reviewed
Dec 10, 2024
| ERRTERM cics_name? | TITLE cics_data_area | LIST cics_data_area | OPCLASS cics_data_area | | ||
| REQID cics_name | LDC cics_name | NLEOM | cics_handle_response)*; | ||
| cics_route: ROUTE (cics_route_body | cics_handle_response)*; | ||
| cics_route_body: ((TIME | AFTER | AT | NLEOM) | (REQID | LDC) cics_name | INTERVAL (cics_hhmmss | cics_zero_digit) | ERRTERM cics_name* | (HOURS | MINUTES | SECONDS) cics_data_value | (TITLE | LIST | OPCLASS) cics_data_area | cics_handle_response)+; |
There was a problem hiding this comment.
Allows multiple sub-operand instances on ERRTERM with *:
Suggest using ERRTERM cics_name? instead.
chacebot
reviewed
Dec 10, 2024
| cics_route: ROUTE (INTERVAL cics_zero_digit | INTERVAL cics_hhmmss | TIME cics_hhmmss | cics_post_after | | ||
| ERRTERM cics_name? | TITLE cics_data_area | LIST cics_data_area | OPCLASS cics_data_area | | ||
| REQID cics_name | LDC cics_name | NLEOM | cics_handle_response)*; | ||
| cics_route: ROUTE (cics_route_body | cics_handle_response)*; |
There was a problem hiding this comment.
Does not need two response handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
Implemented tests for both valid and invalid use case(s).
Checklist: