macOS: if Iceoryx used, add library dir to rpath #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMAKE_INSTALL_RPATH set in the top-level CMakeLists.txt causes the rpath for the Iceoryx library to disappear on installation, but not setting it means the build directories are used in the rpaths of the installed Cyclone library, which also doesn't work. This adds the directory where the iceoryx library is found to the rpath used for installing. I suspect there are better ways, but this should be better than nothing. Signed-off-by: Erik Boasson <eb@ilities.com>
thijsmie
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMAKE_INSTALL_RPATH set in the top-level CMakeLists.txt causes the
rpath for the Iceoryx library to disappear on installation, but not
setting it means the build directories are used in the rpaths of the
installed Cyclone library, which also doesn't work.
This adds the directory where the iceoryx library is found to the rpath
used for installing. I suspect there are better ways, but this should
be better than nothing.
Signed-off-by: Erik Boasson eb@ilities.com