Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing presentation def in json schema #101

Merged

Conversation

wolf4ood
Copy link
Contributor

WHAT

fix missing presentation def in json schema

Closes #97

How was the issue fixed?

Briefly state why the change was necessary.

More context

List other areas that have changed but are not necessarily linked to the main feature. This could be naming changes,
bugs that were encountered and were fixed inline, etc.

@wolf4ood wolf4ood marked this pull request as ready for review November 18, 2024 08:29
@wolf4ood wolf4ood requested a review from jimmarino November 18, 2024 08:29
@wolf4ood
Copy link
Contributor Author

/cc @arnoweiss

@arnoweiss
Copy link
Contributor

Does it make sense to define the presentation property without defining the presentation definition object's structure? This could be tricky because the object is governed outside of DCP. I'd put into question if we need it at all.

@wolf4ood
Copy link
Contributor Author

Unless we want to profile it, probably it worth investigating a schema reference to the presentation definition.

Copy link
Contributor

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll open another issue for this. Thanks for the initial addition here.

@wolf4ood wolf4ood merged commit 82c9e57 into eclipse-dataspace-dcp:main Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PresentationQueryMessage is inconsistent between schemas and spec
3 participants