Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup #104

Merged
merged 5 commits into from
Nov 18, 2024
Merged

fix: cleanup #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6edfb53
feat: add IssuerService to dcp.jsonld context
arnoweiss Nov 18, 2024
70e0125
fix: remove iatp prefix
arnoweiss Nov 18, 2024
de2714a
fix: remove duplicate dcp context object
arnoweiss Nov 18, 2024
b32314b
fix: align on "verificationMethod" as mandated by did-core
arnoweiss Nov 18, 2024
f077bb5
chore: harmonize table layout in VPP with CIP
arnoweiss Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions artifacts/src/main/resources/context/dcp.jsonld
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
}
}
},
"IssuerService": "dcp:IssuerService",
"PresentationQueryMessage": {
"@id": "dcp:PresentationQueryMessage",
"@context": {
Expand Down
2 changes: 1 addition & 1 deletion artifacts/src/main/resources/issuance/example/issuer-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"action": "use",
"constraint": {
"and": {
"leftOperand": "iatp:CredentialPrereq",
"leftOperand": "CredentialPrereq",
"operator": "eq",
"rightOperand": "active"
}
Expand Down
4 changes: 2 additions & 2 deletions artifacts/src/test/java/org/eclipse/dcp/schema/issuance/CredentialObjectSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class CredentialObjectSchemaTest extends AbstractSchemaTest {
"constraint": {
"and": [
{
"leftOperand": "iatp:CredentialPrereq",
"leftOperand": "CredentialPrereq",
"operator": "eq",
"rightOperand": "active"
}
Expand Down Expand Up @@ -76,7 +76,7 @@ public class CredentialObjectSchemaTest extends AbstractSchemaTest {
"constraint": {
"and": [
{
"leftOperand": "iatp:CredentialPrereq",
"leftOperand": "CredentialPrereq",
"operator": "eq",
"rightOperand": "active"
}
Expand Down
127 changes: 0 additions & 127 deletions specifications/context.json
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions specifications/credential.issuance.protocol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,13 +247,13 @@ The following is a non-normative example of a `CredentialStatus` response object
create [=Verifiable Credential] proofs. Key rotation and revocation may be supported in the following way:

1. After a defined `cryptoperiod`, a rotation is initiated, a new key pair is generated and the public key is added
to a `verficationMethod` in the [=Credential Issuer=] DID document. The new private key is used to sign newly
to a `verificationMethod` in the [=Credential Issuer=] DID document. The new private key is used to sign newly
issued [=Verifiable Credential=] proofs.
2. The old private key is decommissioned (archived or destroyed). However, `verificationMethods` in
2. The old private key is decommissioned (archived or destroyed). However, `verificationMethod` in
the [=Credential Issuer=] DID document are retained so existing issued [=Verifiable Credentials=] may be verified.
3. At some point before existing [=Verifiable Credentials=] are set to expire, an [=Credential Issuer=] may make
credential offers for new [=Verifiable Credentials=] to [=Holders=].
4. After a defined period, revocation will be performed where the public key's `verificationMethods` will be removed
4. After a defined period, revocation will be performed where the public key's `verificationMethod` will be removed
from the [=Credential Issuer=] DID document. At this point, any existing [=Verifiable Credentials=] with proofs
signed by the revoked key will not verify.

Expand Down
44 changes: 26 additions & 18 deletions specifications/verifiable.presentation.protocol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,18 @@ exact error code is implementation-specific.
| **Sent by** | [=Verifier=] |
| **HTTP Method** | `POST` |
| **URL Path** | `/presentations/query` |
| **Request** | [`PresentationQueryMessage`](#presentation-query-message) |
| **Request** | [`PresentationQueryMessage`](#presentation-query-message) |
| **Response** | [`PresentationResponseMessage`](#presentation-response-message) `HTTP 2xx` OR `HTTP 4xx` |

### Presentation Query Message

| | |
|--------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| **Schema** | [JSON Schema](./resources/v0.8/presentation/presentation-query-message-schema.json) |
| **Required** | </br>- `@context`: Specifies a valid Json-Ld context ([[json-ld11]], sect. 3.1).</br>- `@type`: A string specifying the `PresentationQueryMessage` type. |
| **Optional** | </br>- `presentationDefinition`: A valid `Presentation Definition` according to the [Presentation Exchange Specification](https://identity.foundation/presentation-exchange/spec/v2.0.0/#presentation-definition).</br>- `scope`: An array of scopes corresponding to Section [[[#scopes]]]. |
| | |
|--------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| **Schema** | [JSON Schema](./resources/v0.8/presentation/presentation-query-message-schema.json) |
| **Required** | - `@context`: Specifies a valid Json-Ld context ([[json-ld11]], sect. 3.1) |
| | - `@type`: A string specifying the `PresentationQueryMessage` type. |
| **Optional** | - `scope`: An array of scopes corresponding to Section [[[#scopes]]]. |
| | - `presentationDefinition`: A valid `Presentation Definition` according to the [Presentation Exchange Specification](https://identity.foundation/presentation-exchange/spec/v2.0.0/#presentation-definition). |

A `PresentationQueryMessage` MUST contain either a `presentationDefinition` or a `scope` parameter. It is an error to
contain both.
Expand Down Expand Up @@ -168,10 +170,12 @@ Verifiable Credential.

### Presentation Response Message

| | |
|--------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| **Schema** | [JSON Schema](./resources/v0.8/presentation/presentation-response-message-schema.json) |
| **Required** | - `@context`: Specifies a valid Json-Ld context ([[json-ld11]], sect. 3.1).</br>- `@type`: A string specifying the `PresentationResponseMessage` type.</br>- `presentation`: An array of [=Verifiable Presentations=]. The [=Verifiable Presentations=] may be strings, JSON objects, or a combination of both depending on the format.</br> |
| | |
|--------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| **Schema** | [JSON Schema](./resources/v0.8/presentation/presentation-response-message-schema.json) |
| **Required** | - `@context`: Specifies a valid Json-Ld context ([[json-ld11]], sect. 3.1). |
| | - `@type`: A string specifying the `PresentationResponseMessage` type. |
| | - `presentation`: An array of [=Verifiable Presentations=]. The [=Verifiable Presentations=] may be strings, JSON objects, or a combination of both depending on the format.</br> |

The following are non-normative examples of the JSON response body:

Expand All @@ -198,10 +202,13 @@ exact error code is implementation-specific.

### Credential Message

| | |
|--------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| **Schema** | [JSON Schema](./resources/v0.8/presentation/credential-message-schema.json) |
| **Required** | - `@context`: Specifies a valid Json-Ld context ([[json-ld11]], sect. 3.1).</br>- `@type`: A string specifying the `CredentialMessage` type.</br>- `requestId`: A string corresponding to the issuance request id.</br>- `credentials`: An array of `CredentialContainer` Json objects as defined in the following. |
| | |
|--------------|----------------------------------------------------------------------------------------------|
| **Schema** | [JSON Schema](./resources/v0.8/presentation/credential-message-schema.json) |
| **Required** | - `@context`: Specifies a valid Json-Ld context ([[json-ld11]], sect. 3.1) |
| | - `@type`: A string specifying the `CredentialMessage` type. |
| | - `requestId`: A string corresponding to the issuance request id. |
| | - `credentials`: An array of `CredentialContainer` Json objects as defined in the following. |

The following is a non-normative example of the Credential Message JSON body:

Expand All @@ -216,7 +223,8 @@ The [Credential Message](#credential-message)'s `credentials` property contains
objects.
The `CredentialContainer` object contains the following properties:

| | |
|--------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| **Schema** | [JSON Schema](./resources/v0.8/presentation/credential-message-schema.json) |
| **Required** | - `@type`: A string specifying the `CredentialContainer` type.</br>- `payload`: A Json Literal ([[json-ld11]], sect. 4.2.2) containing a [=Verifiable Credential=] defined by ([[vc-data-model]]). |
| | |
|--------------|---------------------------------------------------------------------------------------------------------------------------------|
| **Schema** | [JSON Schema](./resources/v0.8/presentation/credential-message-schema.json) |
| **Required** | - `@type`: A string specifying the `CredentialContainer` type. |
| | - `payload`: A Json Literal ([[json-ld11]], sect. 4.2.2) containing a [=Verifiable Credential=] defined by ([[vc-data-model]]). |