Add Json-Ld context, cleanup message types, add proper context URLs #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the IATP Json-Ld context, cleans up missing message type information, and fixes incorrect context URLs. Specifically:
types
attribute totype
onCredentialRequestMessage
so it is consistent throughout all documents and with W3C standards_
was used instead of Camel Case (e.g.presentationDefinition
instead ofpresentation_definition
types
tocredentialTypes
onIssuerMetadata
since renaming it totype
would clash with the ODRL definition oftype
as@type
, which would cause Json-Ld expansion to add the value to theIssuerMetadata
@type property.iatp
as a prefix for consistencyhttps://w3id.org/tractusx-trust/v0.8
for consistencyPlease use GitHub's suggestions feature when making comments so proposed modifications can be directly committed.
Linked Issues
Closes #31