Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Json-Ld context, cleanup message types, add proper context URLs #30

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

jimmarino
Copy link
Contributor

@jimmarino jimmarino commented Oct 25, 2023

This PR adds the IATP Json-Ld context, cleans up missing message type information, and fixes incorrect context URLs. Specifically:

  • Introduces a Json-Ld context that can be (optionally) used for runtimes to perform Json-Ld expansion and basic validation
  • Renames the types attribute to type on CredentialRequestMessage so it is consistent throughout all documents and with W3C standards
  • Replaces inconsistent property naming where _ was used instead of Camel Case (e.g. presentationDefinition instead of presentation_definition
  • Renames types to credentialTypes on IssuerMetadata since renaming it totype would clash with the ODRL definition of type as @type, which would cause Json-Ld expansion to add the value to the IssuerMetadata @type property.
  • Uses iatp as a prefix for consistency
  • Uses the URL https://w3id.org/tractusx-trust/v0.8 for consistency

Please use GitHub's suggestions feature when making comments so proposed modifications can be directly committed.

Linked Issues

Closes #31

@jimmarino jimmarino added the enhancement New feature or request label Oct 25, 2023
Co-authored-by: Enrico Risa <enrico.risa@gmail.com>
@wolf4ood wolf4ood merged commit f4614d9 into eclipse-dataspace-dcp:main Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Json-Ld Context for specification types and terms
4 participants