Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Cleanup and reorganize VPP section #95

Merged
merged 1 commit into from
Nov 14, 2024
Merged

feat: Cleanup and reorganize VPP section #95

merged 1 commit into from
Nov 14, 2024

Conversation

jimmarino
Copy link
Contributor

WHAT

Cleans up and reorganizes the Verifiable Presentation Protocol Section:

  1. Moves terms to the terminology section and improves the definitions
  2. Enhances the VPP flow diagram to include DID resolution
  3. Improve VPP flow description
  4. Moves scope section to the Resolution API where it is used
  5. Removes read | write | all and wildcards from the scope definition as they are no longer used
  6. Add references to terms and definitions
  7. Add normative language

@jimmarino
Copy link
Contributor Author

/cc @arnoweiss

@jimmarino jimmarino mentioned this pull request Nov 14, 2024
Closed
@nikschul nikschul self-requested a review November 14, 2024 11:03
arnoweiss
arnoweiss reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections. Will start work on #96 when merged.

@jimmarino jimmarino merged commit 4311e05 into eclipse-dataspace-dcp:main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikschul nikschul nikschul approved these changes

@arnoweiss arnoweiss arnoweiss approved these changes

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

@wolf4ood wolf4ood wolf4ood approved these changes

@mkollenstart mkollenstart Awaiting requested review from mkollenstart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jimmarino @wolf4ood @paullatzelsperger @arnoweiss @nikschul