Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thing API does not support alternative way of specifying list query parameters #1644

Closed
enenuki opened this issue May 29, 2023 · 1 comment · Fixed by #1652
Closed

Thing API does not support alternative way of specifying list query parameters #1644

enenuki opened this issue May 29, 2023 · 1 comment · Fixed by #1652
Assignees
@thjaeckle
Milestone
3.3.0

Comments

@enenuki
Copy link

enenuki commented May 29, 2023

Ditto thing API supports querying for certain parts of thing, by specifying URL like:
<BASE_URL>/api/2/things/<thingid>?fields=attributes/manufacturer,attributes/type,attributes/productkey

but if we want to use alternative format:
<BASE_URL>/api/2/things/<thingid>?fields=attributes/manufacturer&fields=attributes/type&fields=attributes/productkey

it only returns first attribute (in this case attributes/manufacturer).

While this may seem like minor issue, some libraries (jawax.ws.rs.QueryParam in JAX-RS API) use only the alternative format to serialize their requests, which makes it a bit harder to bypass.

Screenshot from 2023-05-24 16-45-05
Screenshot from 2023-05-24 16-45-18

Ditto version: 3.2.0
@thjaeckle thjaeckle mentioned this issue May 29, 2023
Closed
@thjaeckle
Copy link
Member

Thanks for reporting, @enenuki
That definitely would be a good and simple enhancement for Ditto.
Will work on that..

@thjaeckle thjaeckle added this to the 3.3.0 milestone May 30, 2023
@thjaeckle thjaeckle moved this to Todo in Ditto Planning May 30, 2023
thjaeckle added a commit that referenced this issue Jun 12, 2023
@thjaeckle
#1644 support query params in the style where not comma separation is…
38c388b 
… used, but duplicated keys

* e.g.: `?fields=thingId&fields=policyId`

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle mentioned this issue Jun 12, 2023
Merged
@thjaeckle thjaeckle moved this from Todo to In Progress in Ditto Planning Jun 13, 2023
thjaeckle added a commit that referenced this issue Jun 13, 2023
@thjaeckle
#1644 support query params in the style where not comma separation is…
ba0f739 
… used, but duplicated keys

* e.g.: `?fields=thingId&fields=policyId`

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle moved this from In Progress to Waiting for Approval in Ditto Planning Jun 13, 2023
@thjaeckle thjaeckle self-assigned this Jun 16, 2023
thjaeckle added a commit that referenced this issue Jun 22, 2023
@thjaeckle
#1644 fix filtering out empty field selectors
b02a338 
Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Jun 22, 2023
@thjaeckle
Merge pull request #1652 from eclipse-ditto/feature/more-tolerant-que…
021d043 
…ry-params

#1644 support query params in the style where not comma separation is used, but duplicated keys
@github-project-automation github-project-automation bot moved this from Waiting for Approval to Done in Ditto Planning Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thjaeckle thjaeckle

Labels
None yet
Projects
Ditto Planning
Status: Done
Milestone
3.3.0
2 participants
@enenuki @thjaeckle