-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert client actors from cluster sharding to router pool #1560
Merged
thjaeckle
merged 11 commits into
eclipse-ditto:master
from
bosch-io:feature/revert-client-shard-region
Jan 5, 2023
Merged
Revert client actors from cluster sharding to router pool #1560
thjaeckle
merged 11 commits into
eclipse-ditto:master
from
bosch-io:feature/revert-client-shard-region
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9438959. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
This reverts commit f5af50e. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…ssage envelope for communication between the connection persistence actor and its client actors." This reverts commit 4ce5f39. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…prevent restarts during coordinated shutdown." This reverts commit fd4524b. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
This reverts commit 892aa4a. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…tionPersistenceActorTest." This reverts commit dd63d4c. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…age to restore connection connection announcements." This reverts commit 8ef2450. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…idental restarts." This reverts commit 67c8f3c. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
This reverts commit a8714fd. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…al with shard rebalancing." This reverts commit fdd4a61. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…reporting due to multiple client actors of a connection starting on the same instance." This reverts commit 99639bc. Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
thjaeckle
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharded client actors are not guaranteed to be distributed evenly. It caused uneven load on connectivity instances and made metric reporting inaccurate where the assumption of one client actor per cluster member was made.