Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert client actors from cluster sharding to router pool #1560

Merged

Conversation

yufei-cai
Copy link
Contributor

Sharded client actors are not guaranteed to be distributed evenly. It caused uneven load on connectivity instances and made metric reporting inaccurate where the assumption of one client actor per cluster member was made.

This reverts commit 9438959.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
This reverts commit f5af50e.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…ssage envelope for communication between the connection persistence actor and its client actors."

This reverts commit 4ce5f39.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…prevent restarts during coordinated shutdown."

This reverts commit fd4524b.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
This reverts commit 892aa4a.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…tionPersistenceActorTest."

This reverts commit dd63d4c.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…age to restore connection connection announcements."

This reverts commit 8ef2450.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…idental restarts."

This reverts commit 67c8f3c.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
This reverts commit a8714fd.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…al with shard rebalancing."

This reverts commit fdd4a61.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
…reporting due to multiple client actors of a connection starting on the same instance."

This reverts commit 99639bc.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
@thjaeckle thjaeckle added this to the 3.1.1 milestone Jan 3, 2023
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thjaeckle thjaeckle merged commit d4f021c into eclipse-ditto:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants