Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external message to mqtt publish transform should not fail on blank header values #1565

Merged
merged 1 commit into from
Jan 17, 2023
Merged

external message to mqtt publish transform should not fail on blank header values #1565

merged 1 commit into from
Jan 17, 2023

Conversation

JeffreyThijs
Copy link
Contributor

potential fix for #1563

@JeffreyThijs JeffreyThijs marked this pull request as draft January 13, 2023 16:29
thjaeckle
thjaeckle approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me, so approval from my side 👍
If you mark the PR as "ready" it is good to be merged FMPOV

@thjaeckle thjaeckle added this to the 3.1.2 milestone Jan 16, 2023
@JeffreyThijs
Copy link
Contributor Author

Tested the fix on our cluster and it fixed the problem so ready to merge!

@JeffreyThijs JeffreyThijs marked this pull request as ready for review January 17, 2023 12:52
@thjaeckle thjaeckle merged commit e6dadd1 into eclipse-ditto:master Jan 17, 2023
@thjaeckle thjaeckle mentioned this pull request Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thjaeckle thjaeckle thjaeckle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ditto Planning
Status: Done
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffreyThijs @thjaeckle