Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Build UI with esbuild #1630

Merged
merged 6 commits into from
May 23, 2023

Conversation

thfries
Copy link
Contributor

@thfries thfries commented May 1, 2023

Hello,

please find this PR that introduces bundling of the UI.

I started with webpack but ended up with esbuild. esbuild seems to do exactly what is needed and ended up with a very lean setup.

Some boiler plate code could be removed and some files were structured differently.

The PR is still in draft and needs some more testing (and maybe some more improvements).

Any feedback welcome.

@thjaeckle: Can we introduce the build step as a github action? The index.html in the ui root folder is still the entry point but everything else will be used from the new dist folder. There is a brief readme that describe the build steps and the details can be found in the package.json.

Thomas

Signed-off-by: thfries <thomas.fries0@gmail.com>
@thjaeckle
Copy link
Member

@thfries awesome, thanks
I will soon take a closer look.

Surely I can/will adjust both github actions build and also building of the Docker image for the UI.

@thjaeckle
Copy link
Member

@thfries you forgot to commit the package.json and have it still listed in .gitignore
That would probably need to change ;)

I just wanted to have a look at it an try it out - which of course failed ;)

- removed package.json from gitignore
- included everything except icons and ace in the build process
- updated all to latest incl. bootstrap 5.3

Signed-off-by: thfries <thomas.fries0@gmail.com>
@thfries
Copy link
Contributor Author

thfries commented May 13, 2023

Hi @thjaeckle,
yes package.json would be helpful 😀. Sorry.
I did some more work.
Seems like some libraries are intended to be integrated via cdn and it would need some hick-ups to integrate them in the build process (like ace and bootstrap-icons). So I kept them as is (but ace is then not checked by nom update ☹️)

Signed-off-by: thfries <thomas.fries0@gmail.com>
@thjaeckle thjaeckle added this to the 3.3.0 milestone May 14, 2023
- prepared dockerfile
- fixed stylesheet in operations.html

Signed-off-by: thfries <thomas.fries0@gmail.com>
@thfries
Copy link
Contributor Author

thfries commented May 14, 2023

Hi @thjaeckle,

found some fixes during testing and looks good now (automated test are needed...). So removing draft state.
I prepared the adaption to the docker file, but I m not familiar with using that.

Please let me know if you have remarks. I will try out on another workspace, too (to avoid further missing commits) 😀

@thfries thfries marked this pull request as ready for review May 14, 2023 18:15
@thjaeckle thjaeckle added the UI Issues related to the Ditto explorer UI label May 14, 2023
thfries and others added 2 commits May 17, 2023 14:19
* GH pages
* nightly job
* release jobs

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thfries

Looks good to me, thanks a lot for this :)
I adjusted the GH Actions jobs. I hope that all will work :D

@thjaeckle thjaeckle merged commit 01a7fb8 into eclipse-ditto:master May 23, 2023
@thfries thfries deleted the ui_build_with_esbuild branch May 26, 2023 04:52
@thfries
Copy link
Contributor Author

thfries commented May 26, 2023

Hi @thfries

Looks good to me, thanks a lot for this :) I adjusted the GH Actions jobs. I hope that all will work :D

Hi @thjaeckle , works great. Thanks a lot for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Issues related to the Ditto explorer UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants