-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI - Build UI with esbuild #1630
UI - Build UI with esbuild #1630
Conversation
Signed-off-by: thfries <thomas.fries0@gmail.com>
@thfries awesome, thanks Surely I can/will adjust both github actions build and also building of the Docker image for the UI. |
@thfries you forgot to commit the I just wanted to have a look at it an try it out - which of course failed ;) |
- removed package.json from gitignore - included everything except icons and ace in the build process - updated all to latest incl. bootstrap 5.3 Signed-off-by: thfries <thomas.fries0@gmail.com>
Hi @thjaeckle, |
Signed-off-by: thfries <thomas.fries0@gmail.com>
- prepared dockerfile - fixed stylesheet in operations.html Signed-off-by: thfries <thomas.fries0@gmail.com>
Hi @thjaeckle, found some fixes during testing and looks good now (automated test are needed...). So removing draft state. Please let me know if you have remarks. I will try out on another workspace, too (to avoid further missing commits) 😀 |
* GH pages * nightly job * release jobs Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thfries
Looks good to me, thanks a lot for this :)
I adjusted the GH Actions jobs. I hope that all will work :D
Hi @thjaeckle , works great. Thanks a lot for your support! |
Hello,
please find this PR that introduces bundling of the UI.
I started with webpack but ended up with esbuild. esbuild seems to do exactly what is needed and ended up with a very lean setup.
Some boiler plate code could be removed and some files were structured differently.
The PR is still in draft and needs some more testing (and maybe some more improvements).
Any feedback welcome.
@thjaeckle: Can we introduce the build step as a github action? The
index.html
in the ui root folder is still the entry point but everything else will be used from the newdist
folder. There is a brief readme that describe the build steps and the details can be found in thepackage.json
.Thomas