UI - Migrate to typescript #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thfries <thomas.fries0@gmail.com>
|
Hi @thfries I noticed that the Java sources are compiled when doing a UI PR. |
-add ditto error description to error toast
|
Oh, where is the compilation of java files triggered? Did another change to the error display, because the ditto error description was ignored. Rest seems good now. |
|
I forgot: ditto sandbox seems to be down? |
Thanks for notifying.. I renewed the certificate which was outdated. |
* excluded ui/ changes from "normal" maven build on PRs Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @thjaeckle,
I switched the whole project to typescript.
By now, types were only introduced were needed. There are a lot of further improvements possible, that could be added over time.
Already some smaller issues were discovered, too. And I still want to investigate.
Sorry for not picking the issues with the features, but I m sure this pays off over time. I try to not block this for too long.