-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1739 provide the traceparent header as MDC value in logs #1740
Conversation
ad15325
to
7635ddb
Compare
@alstanchev this PR would also be cool to be included in 3.4.0 I could simplify the loggers also quite a bit. I also fixed that the |
I have mentioned the #1739 issue or do you want the PR to be mentioned specifically? |
When there is an issue and a PR I normally only mention and link the issue ;) I also pinged you about reviewing, but you're right .. release notes would also be good - I could also do that however.. |
* generify the fields to provide to the MDC in CommonMdcEntryKey enum * rename "x-correlation-id" in logs to just "correlation-id" * exchange some places where only correlationId was extracted from a map of headers with parsing all the headers for MDC worthy fields Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
… level as "intLevel" Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
…ent-span-id" Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
210d81d
to
707c773
Compare
… chart Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@alstanchev @kalinkostashki Could you please have a look? Still missing an approval here .. :) |
i am on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves: #1739