Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update maven plugins to latest versions #1753

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

thjaeckle
Copy link
Member

  • and update legal / dependencies documents accordingly

* and update legal / dependencies documents accordingly

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle added this to the 3.4.0 milestone Sep 18, 2023
@thjaeckle thjaeckle self-assigned this Sep 18, 2023
…uilderTest

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
…uture.completedStage` instead of `CompletableFuture.completedFuture`

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle
Copy link
Member Author

@alstanchev @kalinkostashki I updated all Maven plugins to their latest versions and also e.g. the used Scala version.
Found an issue when using CompletableFuture.completedStage() with new Scala 2.13.12 - so I replaced use of this with CompletableFuture.completedFuture() which works.

Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thjaeckle thjaeckle merged commit d0fa186 into master Sep 19, 2023
@thjaeckle thjaeckle deleted the update-maven-plugins branch November 30, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants