Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BASIC authentication for devops/status users while using Helm deployment and Ingress Controller #1760

Merged

Conversation

RockyMM
Copy link
Contributor

@RockyMM RockyMM commented Sep 29, 2023

At the moment all /devops and /status paths are routed through api Ingress resource. Since the introduction of BASIC auth for ditto user(s), /devops and /status paths could not be authenticated with devops/status users.

This PR introduces a new Ingress resource to control devops and status paths. The authorization header is simply forwarded to the gateway.

Another update is parameterizing preStop wait time on the IngressController. More info in the comments in the values.yaml.

Also Ingress Controller version is updated to 1.9.0. With this all regex-type paths are given ImplementationSpecific pathType instead of Prefix.

@RockyMM
Copy link
Contributor Author

RockyMM commented Sep 29, 2023

Important thing to note - I could not test successfully with the main branch. None of the pods gateway, things or thingssearch could successfully start. What I see is:

Running CoordinatedShutdown with reason [JvmExitReason]

Seems like a akka/pekko problem.

I cherry picked all commits over release-3.3 branch and that worked well.

Copy link
Contributor

@kalinkostashki kalinkostashki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thjaeckle thjaeckle added this to the 3.4.0 milestone Oct 2, 2023
This specialized Ingress resource is to allow basic auth of devops path
with `devops` and `status` users through Ingress Controller.
Previously these paths were assigned to api Ingress, and they required
ditto user credentials.
@RockyMM RockyMM force-pushed the feature/devops-basic-auth-ingress branch from 7fc93f1 to 52325c5 Compare October 2, 2023 11:19
@thjaeckle thjaeckle merged commit 3309a57 into eclipse-ditto:master Oct 3, 2023
8 checks passed
@RockyMM RockyMM deleted the feature/devops-basic-auth-ingress branch November 14, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants