Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement benchmark-tool, add blogpost with benchmark results #1765

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Implement benchmark-tool, add blogpost with benchmark results #1765

merged 3 commits into from
Oct 9, 2023

Conversation

vvasilevbosch
Copy link
Contributor

No description provided.

@vvasilevbosch vvasilevbosch force-pushed the feature/ditto-benchmark-tool branch from 4cb42b4 to 3bf862a Compare October 5, 2023 14:32
@vvasilevbosch
Implement benchmark-tool, based on k6-runner
c138c40 
Signed-off-by: Vasil Vasilev <vasil.vasilev@bosch.com>
@vvasilevbosch vvasilevbosch force-pushed the feature/ditto-benchmark-tool branch from 3bf862a to c138c40 Compare October 5, 2023 14:37
thjaeckle
thjaeckle requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vvasilevbosch

I took a first look, mainly at the blogpost and added some comments about date of the post and mainly links which were not correct.

The blogpost already looks really great - awesome that you used screenshots and tables and structured it so well, so it is good to read 👍

@thjaeckle
Copy link
Member

thjaeckle commented Oct 6, 2023 •
edited
Loading

It might also be useful to document the Ditto version (and also MongoDB version, Kafka version) you used to run the benchmark ..

@vvasilevbosch
Add escapes for placeholders, fix urls, add dependency versions, add …
af21d46 
…myself as author

Signed-off-by: Vasil Vasilev <vasil.vasilev@bosch.com>
@thjaeckle
Copy link
Member

@vvasilevbosch the filename of the blogpost should match the link in the header of the post - the filename is still the old date

from my point of view we could aim for publishing on Monday, 09.10.2023 - I think the post is in a good shape - will do another proof-reading. 👍

@vvasilevbosch
Rename post filename to match the permalink
a17daaa 
Signed-off-by: Vasil Vasilev <vasil.vasilev@bosch.com>
thjaeckle
thjaeckle approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

Thanks a lot for this great contribution @vvasilevbosch

If you don't mind, I will publish the Blogpost today ..

@thjaeckle thjaeckle merged commit 5ce30be into eclipse-ditto:master Oct 9, 2023
1 of 2 checks passed
@thjaeckle thjaeckle added this to the 3.4.0 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thjaeckle thjaeckle thjaeckle approved these changes

Assignees

@vvasilevbosch vvasilevbosch

Labels
None yet
Projects
Ditto Planning
Status: Done
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vvasilevbosch @thjaeckle