Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide new option for "if-equal" header: "skip-minimizing-merge" #1772

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

thjaeckle
Copy link
Member

  • which reduces the part of a merge/patch command to the actually changed elements, removing non-changed elements
  • this reduces e.g. required storage in the MongoDB by a lot, if redundant data is sent often
  • this also reduces the event payload to the actually changed parts of the thing

Would want to add this to 3.4.0 as it would be a really powerful feature in order to reduce:

  • payload stored in MongoDB journal entries
  • payload size in events

It is only supported:

  • for "merge thing commands"
  • and if the header if-equal: skip-minimizing-merge is used

@thjaeckle thjaeckle added this to the 3.4.0 milestone Oct 12, 2023
@alstanchev alstanchev self-requested a review October 12, 2023 13:43
@thjaeckle
Copy link
Member Author

thjaeckle commented Oct 12, 2023

@alstanchev I still want to provide some unit tests and documentation .. :)

.. edit: done .. FMPOV ready to be reviewed :)

@thjaeckle thjaeckle self-assigned this Oct 12, 2023
* which reduces the part of a merge/patch command to the actually changed elements, removing non-changed elements
* this reduces e.g. required storage in the MongoDB by a lot, if redundant data is sent often
* this also reduces the event payload to the actually changed parts of the thing

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
* also added documentation
* enhanced release notes + blogpost about release with last-minute addition

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle force-pushed the feature/skip-minimizing-merge branch from 7c62f35 to 332c155 Compare October 16, 2023 17:27
Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍 👍

@thjaeckle thjaeckle merged commit 976e285 into master Oct 17, 2023
2 checks passed
@thjaeckle thjaeckle deleted the feature/skip-minimizing-merge branch October 17, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants