Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1631 fix putting metadata on a single property did not work #1774

Merged
merged 1 commit into from
Oct 17, 2023
Merged

#1631 fix putting metadata on a single property did not work #1774

merged 1 commit into from
Oct 17, 2023

Conversation

thjaeckle
Copy link
Member

fixes: #1631

@thjaeckle
#1631 fix putting metadata on a single property did not work
0c29642 
Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle added the bug label Oct 15, 2023
@thjaeckle thjaeckle added this to the 3.4.0 milestone Oct 15, 2023
@thjaeckle thjaeckle self-assigned this Oct 15, 2023
@thjaeckle
Copy link
Member Author

@alstanchev @kalinkostashki could you please have a look?
fix is quite easy .. I verified with a unit test that it is now working

alstanchev
alstanchev approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@thjaeckle thjaeckle merged commit b00419c into master Oct 17, 2023
@thjaeckle thjaeckle deleted the bugfix/put-metadata-on-single-property branch October 17, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alstanchev alstanchev alstanchev approved these changes

Assignees

@thjaeckle thjaeckle

Labels
bug
Projects
Ditto Planning
Status: Done
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

put-metadata does not work as expected since 3.x
2 participants
@thjaeckle @alstanchev