Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix preserving DittoHeaders when encountering a JsonParseException #1792

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix preserving DittoHeaders when encountering a JsonParseException #1792

merged 1 commit into from
Nov 3, 2023

Conversation

thjaeckle
Copy link
Member

  • e.g. containing correlation-id, trace-context, etc.

@thjaeckle
fix preserving DittoHeaders when encountering a JsonParseException
8be61d5 
* e.g. containing correlation-id, trace-context, etc.
@thjaeckle thjaeckle added the bug label Nov 3, 2023
@thjaeckle thjaeckle added this to the 3.4.1 milestone Nov 3, 2023
@thjaeckle thjaeckle self-assigned this Nov 3, 2023
alstanchev
alstanchev approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very nice improvement.
LGTM 👍

@thjaeckle thjaeckle merged commit ce55fc4 into master Nov 3, 2023
2 checks passed
thjaeckle added a commit that referenced this pull request Nov 6, 2023
@thjaeckle
fix regression introduced in #1792
fe58303 
* DittoJsonException was not consistently handling `wrapJsonRuntimeException` in different overloaded styles, e.g. the `UnsupportedOperationException` was not catched everywhere
* fixed that

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
alstanchev added a commit that referenced this pull request Nov 6, 2023
@alstanchev
Merge pull request #1796 from eclipse-ditto/bugfix/ditto-json-excepti…
23f057a 
…on-handling

fix regression introduced in #1792
thfries pushed a commit to thfries/ditto that referenced this pull request Nov 14, 2023
@thjaeckle @thfries
fix regression introduced in eclipse-ditto#1792
9b2896a 
* DittoJsonException was not consistently handling `wrapJsonRuntimeException` in different overloaded styles, e.g. the `UnsupportedOperationException` was not catched everywhere
* fixed that

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle deleted the bugfix/preserve-ditto-headers-json-parsing-errors branch November 30, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alstanchev alstanchev alstanchev approved these changes

Assignees

@thjaeckle thjaeckle

Labels
bug
Projects
Ditto Planning
Status: Done
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@thjaeckle @alstanchev