UI policy imports #1793
UI policy imports #1793
Conversation
There was a problem hiding this comment.
Thanks a lot @thfries for the policy imports addition to the UI.
I must say that I really like it - the thoughts you put into selecting the checkboxes for importing "implicit", "explicit" and "never" marked policy entries shows that you really understood the approach 👍 :)
I also really like the "Recent policies" idea.
I have a few remarks which might be worth to consider:
- the tabs for policies are now: "CRUD Policy" and "Policy JSON"
- for things however, the tabs with similar names have different meaning: "CRUD" for things shows the JSON Editor
- so for "CRUD Policy" I was also expecting the JSON editor ..
- maybe this can be solved by also renaming the Things "CRUD" tab to e.g. just "JSON"
- the Policy tabs I would then e.g. name: "Manage" and "JSON"
- or another idea:
- have 3 Tabs: "Imports", "Entries" and "JSON"
- Both, Policy imports and entries can become quite long and I don't see that it really is required to have them on the same tab
- the heading "PolicyImports" misses a whitespace
- the label showing "ImportPolicyId" I would rather change to "Imported Policy ID"
- for creating new "Policy Imports", "Entries", "Subjects" or "Resources" in the "CRUD Policy" tab, the Button should have the label "Create" instead of "Edit" when a new entry can be added
- the same would also be good for Thing features to have it behave equally
Nice to have:
- what I missed - even more than the 2 suggestions you provided - is the ability to navigate to a imported Policy
- I would suggest to do that in similar way than the clipboard icon in the "Recent policies" list: Provide an icon at the right of each "Policy import" with an arrow or so - when clicking on it, load the imported policy as currently "selected" policy
- the previously selected policy would automatically still be available in the "Recent policy" list
|
Thanks for the feedback. Agree to all points. I like the idea with the three tabs. |
|
Hi @thjaeckle, |
|
Thanks a ton, @thfries |
thfries
force-pushed
the
ui_policy_imports
branch
from
7f69c40 to
ef32223
Compare
Signed-off-by: thfries <thomas.fries0@gmail.com>
- Changed naming CRUD, JSON and Manage - Fixed typos in labels - Splitted tabs for entries and imports - Fixed things search field delete button - Search button now in primary color - Empty crud toolbar now called create instead of edit Signed-off-by: thfries <thomas.fries0@gmail.com>
- Update bootstrap-icons for new copy icon - Fixed color of selected copy icon - Allow additional actions in table rows - Clipboard copy value now explicit and not guessed from sibling html - Policy import allows navigation - fixed SSE mapping of incoming messages Signed-off-by: thfries <thomas.fries0@gmail.com>
- disable send buttons when no thing or feature is selected Signed-off-by: thfries <thomas.fries0@gmail.com>
Signed-off-by: thfries <thomas.fries0@gmail.com>
thfries
force-pushed
the
ui_policy_imports
branch
from
ef32223 to
b9d874d
Compare
|
Hi @thfries One thing:
In addition, I noticed a weird behavior in the "Things" table. At least when I start Ditto locally and connect the UI to that, I cannot select any longer any thing - for some things I will get an error in the SSE (canceled) which is tried to be opened when selecting another Thing. *Edit: On "master" this is not a problem (connecting to the same local Ditto), so apparently this was introduced in this PR. |
|
oh, no. This must be a caused by a change in 876c30b on messagesIncoming.ts. I was forced by typescript to change there. I missed that, sorry. Let me check. I renamed
We could use "JSON" instead of "Manage" but is it then clear that you can create, edit and delete entities there? But I also see this inconsistency... |
Signed-off-by: thfries <thomas.fries0@gmail.com>
|
Hi @thjaeckle, I fixed the issue. Reason for this bug was something different. Very annoying that these types of errors are just dropped silently. More sustainable fix would be to introduce an interface for Was about to change "Manage" to "JSON", too. But on the Environments page, there is "Manage" and "JSON" already next to each other... So no idea here |
There was a problem hiding this comment.
@thfries cool, the bug is fixed 👍
Right, I also agree that "Manage" does make more sense in some cases.
So I think the way it currently is, is ok 👌
Would merge this PR if nothing else comes up.
Thanks a lot for the contribution.
please find this bigger pull requests for policy imports (fixes #1700). Would be nice to get feedback from users that use policy imports.
Also a "full json" editor for the policy was added. Including some templates for policies (I took some from the documentation but may be other templates make sense. e.g. is there a "minimal policy"?)
The overall status is stable. Two things could be improved in future