enhance "Incoming Thing Updates" in UI to provide more information at a glance #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a glance * added 2 columns "Action" (e.g. showing "merged" or "modified") and "Path" (showing on which level) to the table * prioritized "_context" over "features" and "attributes" to extract "Field(s)" from - only done for actions on path "/" * added a selection to the "Thing Update Detail" view which information to display from the selected event Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
|
Works like a charm. Nice! LGTM |
|
I think it is OK to be collapsed by default, as on new events there will be the indicator next to the heading of the section that there is something happening there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thfries again, I would appreciate your input on this :)
I noticed you swapped reading from either "_context" or features/attributes in
getColumnValues()method recently.That does not work, for newer Ditto versions both are present, so we have to first check for existence of
["_context"].value(which Ditto 3.4 provides) and can then fall-back to plain features/attributes to determining the updated "Field(s)".This PR improves displaying "merge" and also "delete" events a lot - because "Action" and "Path" are shown in the table.