Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1844 fix resolving revision or timestamp from the future was not directly denied #1845

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

thjaeckle
Copy link
Member

Fixes: #1844

…ectly denied

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle added the bug label Dec 18, 2023
@thjaeckle thjaeckle self-assigned this Dec 18, 2023
@thjaeckle thjaeckle added this to the 3.4.4 milestone Dec 18, 2023
…l-revision`

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle
Copy link
Member Author

@alstanchev @kalinkostashki Could you please review?
Small fix, huge impact when using the history api.

Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thjaeckle thjaeckle merged commit 28bccd8 into master Dec 19, 2023
3 checks passed
@thjaeckle thjaeckle deleted the bugfix/1844-fix-resolving-future-revision branch December 19, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fetching a thing at a non-existing historical revision (e.g. in future) results in status 503
2 participants