Add possibility to customize image used for pod-deletion-cost annotation patching job #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion patching Signed-off-by: Vit Holasek <xvh@seznam.cz>
thjaeckle
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
@kyberpunk that's a great addition to the chart, thanks a lot 👍
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I would like to add possibility for using custom images and private docker registries also for pod-deletion-cost annotation patching jobs. It works similar way as for Ditto deployments. Image is still the same by default so it is backwards compatible.
Thank you.