Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable configuring even more flexibly indexes to hint for in Cleanup aggregations #1961

Merged

Conversation

thjaeckle
Copy link
Member

  • also create indexes speeding up the aggregation on snapshot collection

@thjaeckle thjaeckle added the bug label Jun 11, 2024
@thjaeckle thjaeckle added this to the 3.5.8 milestone Jun 11, 2024
@thjaeckle thjaeckle self-assigned this Jun 11, 2024
@thjaeckle thjaeckle force-pushed the bugfix/aggregate-index-hint branch from 35053d7 to 7753e04 Compare June 11, 2024 19:38
@thjaeckle
Copy link
Member Author

thjaeckle commented Jun 11, 2024

@kalinkostashki @alstanchev follow-up of bugfix #1956 .. it is not sufficient to provide a single hint - but conditionally on the $match done in the aggregation.
This fix also adds the option (by default disabled) to add 2 indexes which should improve the aggregation queries.

By default I now left all index hints as null - to assume the MongoDB Query Planner does its job well.

…p aggregations

* also create indexes speeding up the aggregation on snapshot collection

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle force-pushed the bugfix/aggregate-index-hint branch from 7753e04 to e18870a Compare June 12, 2024 05:53
Copy link
Contributor

@alstanchev alstanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@thjaeckle thjaeckle merged commit f50c7d5 into eclipse-ditto:master Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants