removed unused DITTO_POLICIES_ENFORCER_CACHE_MAX_SIZE in thingssearch

[kalinkostashki]

• this property is only used for the policies service in CachingPolicyEnforcerProvider.java and PolicyEnforcerProviderExtension.java

[thjaeckle]

Thanks @kalinkostashki for the PR - you're right - those are not used in things-search.

However, there are also more config keys to the DITTO_POLICIES_ENFORCER_CACHE_*- we should also remove them, right?

And what about the Helm values.yaml?
.Values.thingsSearch.config.updater.stream.policiesEnforcer.cache. can likely be removed from that as well, right?

[kalinkostashki]

Thanks @kalinkostashki for the PR - you're right - those are not used in things-search.

However, there are also more config keys to the DITTO_POLICIES_ENFORCER_CACHE_*- we should also remove them, right?

And what about the Helm values.yaml? .Values.thingsSearch.config.updater.stream.policiesEnforcer.cache. can likely be removed from that as well, right?

I don't we should remove Values.thingsSearch.config.updater.stream.policiesEnforcer.cache. as those are used to set THINGS_SEARCH_UPDATER_STREAM_POLICY_CACHE* options.

[thjaeckle]

I don't we should remove Values.thingsSearch.config.updater.stream.policiesEnforcer.cache. as those are used to set THINGS_SEARCH_UPDATER_STREAM_POLICY_CACHE* options.

Oh, good catch - then they were used by 2 places .. which is already a bad smell :D

Your changes LGTM 👍