Some cleanups in ecal_config_initializer.

eclipse-ecal · Nov 28, 2024 · dd83f43 · dd83f43
1 parent bebf5b6
commit dd83f43
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/ecal/core/src/config/ecal_config_initializer.cpp b/ecal/core/src/config/ecal_config_initializer.cpp
@@ -210,16 +210,16 @@ namespace
   std::vector<std::string> ConvertArgcArgvToVector(int argc_, char** argv_)
   {
     std::vector<std::string> arguments;
-    if (argc_ > 0 && argv_ != nullptr)
+    if (argv_ == nullptr) return arguments;
+
+    for (size_t i = 0; i < static_cast<size_t>(argc_); ++i)
     {
-      for (size_t i = 0; i < static_cast<size_t>(argc_); ++i)
+      if (argv_[i] != nullptr)
       {
-        if (argv_[i] != nullptr)
-        {
-          arguments.emplace_back(argv_[i]);
-        }
+        arguments.emplace_back(argv_[i]);
       }
     }
+
     return arguments;
   }
 }
@@ -271,9 +271,7 @@ namespace eCAL
       InitFromFile(g_default_ini_file);
     }
 
-    Configuration::Configuration()
-    {
-    }
+    Configuration::Configuration() = default;
 
     std::string Configuration::GetYamlFilePath()
     {