[Logging] Introducing Provider/Receiver pattern for logging #1831

Peguen · 2024-12-02T14:17:21Z

Description

Split of the ecal logging mechanism into a provider and receiver class. Receiver class is an UDP receiver for all log messages. The receiving can be enabled/disabled by config. Additionally, it must be stated explicitly that the receiving component needs to be initialized when eCAL::Initialize(...) is called. Receiving is by default disabled.

Tests and apps adapted towards this logic.

KerstinKeller

I know it's still a draft, but I just read over it quickly and wanted to post a few things which came to my mind, before I forget them.

ecal/core/src/ecal_global_accessors.h

ecal/core/src/ecal_globals.cpp

ecal/core/src/logging/config/attributes/ecal_log_provider_attributes.h

ecal/core/src/logging/config/attributes/ecal_log_receiver_attributes.h

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 68. Check the log or trigger a new build to see more.

ecal/core/src/config/builder/logging_attribute_builder.cpp

ecal/core/src/logging/ecal_log_provider.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 48. Check the log or trigger a new build to see more.

ecal/core/src/logging/ecal_log_provider.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 29. Check the log or trigger a new build to see more.

github-actions · 2024-12-04T12:13:59Z

ecal/core/src/logging/config/attributes/ecal_log_receiver_attributes.h

+#include <string>
+
+#include <ecal/ecal_log_level.h>
+


warning: included header ecal_log_level.h is not used directly [misc-include-cleaner]

Suggested change

github-actions · 2024-12-04T12:13:59Z

ecal/core/src/logging/ecal_log_provider.cpp

+      const std::string tstring = get_time_str();
+
+      m_logfile_name = m_attributes.file.path + tstring + "_" + m_attributes.unit_name + "_" + std::to_string(m_attributes.process_id) + ".log";
+      m_logfile = fopen(m_logfile_name.c_str(), "w");


warning: assigning newly created 'gsl::owner<>' to non-owner 'FILE *' (aka '_IO_FILE *') [cppcoreguidelines-owning-memory]

m_logfile = fopen(m_logfile_name.c_str(), "w"); ^

github-actions · 2024-12-04T12:13:59Z

ecal/core/src/logging/ecal_log_provider.cpp

+      const std::string tstring = get_time_str();
+
+      m_logfile_name = m_attributes.file.path + tstring + "_" + m_attributes.unit_name + "_" + std::to_string(m_attributes.process_id) + ".log";
+      m_logfile = fopen(m_logfile_name.c_str(), "w");


warning: no header providing "fopen" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_provider.cpp:23:

- #include <ecal/ecal_time.h> + #include <cstdio> + #include <ecal/ecal_time.h>

github-actions · 2024-12-04T12:13:59Z

ecal/core/src/logging/ecal_log_provider.cpp

+
+    bool CLogProvider::StartUDPLogging()
+    {
+      const eCAL::UDP::SSenderAttr attr = Logging::UDP::ConvertToIOUDPSenderAttributes(m_attributes.udp_sender);


warning: no header providing "eCAL::UDP::SSenderAttr" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_provider.cpp:20:

- #include "serialization/ecal_serialize_logging.h" + #include "io/udp/ecal_udp_sender_attr.h" + #include "serialization/ecal_serialize_logging.h"

github-actions · 2024-12-04T12:13:59Z

ecal/core/src/logging/ecal_log_provider.cpp

+    bool CLogProvider::StartUDPLogging()
+    {
+      const eCAL::UDP::SSenderAttr attr = Logging::UDP::ConvertToIOUDPSenderAttributes(m_attributes.udp_sender);
+      m_udp_logging_sender = std::make_unique<eCAL::UDP::CSampleSender>(attr);


warning: no header providing "eCAL::UDP::CSampleSender" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_provider.cpp:20:

- #include "serialization/ecal_serialize_logging.h" + #include "io/udp/ecal_udp_sample_sender.h" + #include "serialization/ecal_serialize_logging.h"

github-actions · 2024-12-04T12:14:01Z

ecal/core/src/logging/ecal_log_receiver.cpp

+{
+  namespace Logging
+  {
+    CLogReceiver::CLogReceiver(const SReceiverAttributes& attr_)


warning: no header providing "eCAL::Logging::SReceiverAttributes" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_receiver.cpp:22:

- #include "serialization/ecal_serialize_logging.h" + #include "logging/config/attributes/ecal_log_receiver_attributes.h" + #include "serialization/ecal_serialize_logging.h"

github-actions · 2024-12-04T12:14:01Z

ecal/core/src/logging/ecal_log_receiver.cpp

+      if (m_attributes.udp_enabled && m_attributes.receive_enabled)
+      {
+        // set logging receive network attributes
+        const eCAL::UDP::SReceiverAttr attr = Logging::UDP::ConvertToIOUDPReceiverAttributes(m_attributes.udp_receiver);


warning: no header providing "eCAL::UDP::SReceiverAttr" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_receiver.cpp:22:

- #include "serialization/ecal_serialize_logging.h" + #include "io/udp/ecal_udp_receiver_attr.h" + #include "serialization/ecal_serialize_logging.h"

github-actions · 2024-12-04T12:14:01Z

ecal/core/src/logging/ecal_log_receiver.cpp

+        const eCAL::UDP::SReceiverAttr attr = Logging::UDP::ConvertToIOUDPReceiverAttributes(m_attributes.udp_receiver);
+
+        // start logging receiver
+        m_log_receiver = std::make_shared<eCAL::UDP::CSampleReceiver>(attr, std::bind(&CLogReceiver::HasSample, this, std::placeholders::_1), std::bind(&CLogReceiver::ApplySample, this, std::placeholders::_1, std::placeholders::_2));


warning: no header providing "eCAL::UDP::CSampleReceiver" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_receiver.cpp:22:

- #include "serialization/ecal_serialize_logging.h" + #include "io/udp/ecal_udp_sample_receiver.h" + #include "serialization/ecal_serialize_logging.h"

github-actions · 2024-12-04T12:14:01Z

ecal/core/src/logging/ecal_log_receiver.cpp

+        const eCAL::UDP::SReceiverAttr attr = Logging::UDP::ConvertToIOUDPReceiverAttributes(m_attributes.udp_receiver);
+
+        // start logging receiver
+        m_log_receiver = std::make_shared<eCAL::UDP::CSampleReceiver>(attr, std::bind(&CLogReceiver::HasSample, this, std::placeholders::_1), std::bind(&CLogReceiver::ApplySample, this, std::placeholders::_1, std::placeholders::_2));


warning: no header providing "std::bind" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_receiver.cpp:24:

- #include <iostream> + #include <functional> + #include <iostream>

github-actions · 2024-12-04T12:14:01Z

ecal/core/src/logging/ecal_log_receiver.cpp

+        const eCAL::UDP::SReceiverAttr attr = Logging::UDP::ConvertToIOUDPReceiverAttributes(m_attributes.udp_receiver);
+
+        // start logging receiver
+        m_log_receiver = std::make_shared<eCAL::UDP::CSampleReceiver>(attr, std::bind(&CLogReceiver::HasSample, this, std::placeholders::_1), std::bind(&CLogReceiver::ApplySample, this, std::placeholders::_1, std::placeholders::_2));


warning: no header providing "std::make_shared" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_receiver.cpp:25:

+ #include <memory>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 36. Check the log or trigger a new build to see more.

github-actions · 2024-12-04T15:05:38Z

app/mon/mon_gui/src/ecalmon.cpp

@@ -71,7 +71,7 @@ Ecalmon::Ecalmon(QWidget *parent)
  , monitor_error_counter_(0)
 {
  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring);
+  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::Default" is directly included [misc-include-cleaner]

app/mon/mon_gui/src/ecalmon.cpp:24:

- #include "widgets/about_dialog/about_dialog.h" + #include "ecal/ecal_init.h" + #include "widgets/about_dialog/about_dialog.h"

github-actions · 2024-12-04T15:05:38Z

app/mon/mon_gui/src/ecalmon.cpp

@@ -71,7 +71,7 @@
  , monitor_error_counter_(0)
 {
  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring);
+  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::Monitoring" is directly included [misc-include-cleaner]

eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive); ^

github-actions · 2024-12-04T15:05:38Z

app/mon/mon_gui/src/ecalmon.cpp

@@ -71,7 +71,7 @@
  , monitor_error_counter_(0)
 {
  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring);
+  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::UDPLogReceive" is directly included [misc-include-cleaner]

eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive); ^

github-actions · 2024-12-04T15:05:38Z

app/mon/mon_gui/src/ecalmon.cpp

@@ -71,7 +71,7 @@
  , monitor_error_counter_(0)
 {
  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring);
+  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/mon/mon_gui/src/ecalmon.cpp:24:

- #include "widgets/about_dialog/about_dialog.h" + #include "ecal/ecal_core.h" + #include "widgets/about_dialog/about_dialog.h"

github-actions · 2024-12-04T15:05:38Z

app/mon/mon_tui/src/main.cpp

@@ -32,7 +32,7 @@ int main(int argc, char** argv)
 {
  auto args = ParseArgs(argc, argv);

-  auto status = eCAL::Initialize(0, nullptr, "eCALMon TUI", eCAL::Init::Default | eCAL::Init::Monitoring);
+  auto status = eCAL::Initialize(0, nullptr, "eCALMon TUI", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::Default" is directly included [misc-include-cleaner]

app/mon/mon_tui/src/main.cpp:28:

- #include "tui/tui.hpp" + #include "ecal/ecal_init.h" + #include "tui/tui.hpp"

github-actions · 2024-12-04T15:05:40Z

app/rec/rec_gui/src/main.cpp

@@ -136,7 +136,7 @@
  }

  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring);
+  eCAL::Initialize(0, nullptr, "eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::UDPLogReceive" is directly included [misc-include-cleaner]

eCAL::Initialize(0, nullptr, "eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive); ^

github-actions · 2024-12-04T15:05:40Z

app/rec/rec_gui/src/main.cpp

@@ -136,7 +136,7 @@
  }

  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring);
+  eCAL::Initialize(0, nullptr, "eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/rec/rec_gui/src/main.cpp:19:

- #include "ecalrec_gui.h" + #include "ecal/ecal_core.h" + #include "ecalrec_gui.h"

github-actions · 2024-12-04T15:05:40Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@ namespace eCAL
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize(0, nullptr, "", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize(0, nullptr, "", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::Default" is directly included [misc-include-cleaner]

app/rec/rec_server_core/src/rec_server_impl.cpp:21:

- #include "recorder_settings.h" + #include "ecal/ecal_init.h" + #include "recorder_settings.h"

github-actions · 2024-12-04T15:05:40Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize(0, nullptr, "", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize(0, nullptr, "", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::Monitoring" is directly included [misc-include-cleaner]

eCAL::Initialize(0, nullptr, "", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive); ^

github-actions · 2024-12-04T15:05:41Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize(0, nullptr, "", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize(0, nullptr, "", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::UDPLogReceive" is directly included [misc-include-cleaner]

eCAL::Initialize(0, nullptr, "", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive); ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 22. Check the log or trigger a new build to see more.

github-actions · 2024-12-04T15:24:40Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@ namespace eCAL
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize(0, nullptr, "", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize(0, nullptr, "", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/rec/rec_server_core/src/rec_server_impl.cpp:21:

- #include "recorder_settings.h" + #include "ecal/ecal_core.h" + #include "recorder_settings.h"

github-actions · 2024-12-04T15:24:40Z

ecal/core/src/ecal_globals.cpp

+      }
+    }
+
+    if ((components_ & Init::UDPLogReceive) != 0u)


warning: no header providing "eCAL::Init::UDPLogReceive" is directly included [misc-include-cleaner]

if ((components_ & Init::UDPLogReceive) != 0u) ^

github-actions · 2024-12-04T15:24:40Z

ecal/core/src/ecal_globals.cpp

+    {
+      if (log_udp_receiver_instance == nullptr)
+      {
+        log_udp_receiver_instance = std::make_unique<Logging::CLogReceiver>(eCAL::Logging::BuildLoggingReceiverAttributes(GetLoggingConfiguration(), GetRegistrationConfiguration(), GetTransportLayerConfiguration()));


warning: no header providing "eCAL::Logging::CLogReceiver" is directly included [misc-include-cleaner]

ecal/core/src/ecal_globals.cpp:24:

+ #include "logging/ecal_log_receiver.h"

github-actions · 2024-12-04T15:24:40Z

ecal/core/src/logging/config/builder/udp_attribute_builder.cpp

@@ -25,7 +25,7 @@ namespace eCAL
  {
    namespace UDP
    {
-      eCAL::UDP::SSenderAttr ConvertToIOUDPSenderAttributes(const Logging::SUDPSender& sender_attr_)
+      eCAL::UDP::SSenderAttr ConvertToIOUDPSenderAttributes(const Logging::SProviderAttributes::SUDPSender& sender_attr_)


warning: no header providing "eCAL::Logging::SProviderAttributes" is directly included [misc-include-cleaner]

ecal/core/src/logging/config/builder/udp_attribute_builder.cpp:20:

+ #include "logging/config/attributes/ecal_log_provider_attributes.h"

github-actions · 2024-12-04T15:24:40Z

ecal/core/src/logging/config/builder/udp_attribute_builder.cpp

@@ -25,7 +25,7 @@
  {
    namespace UDP
    {
-      eCAL::UDP::SSenderAttr ConvertToIOUDPSenderAttributes(const Logging::SUDPSender& sender_attr_)
+      eCAL::UDP::SSenderAttr ConvertToIOUDPSenderAttributes(const Logging::SProviderAttributes::SUDPSender& sender_attr_)


warning: no header providing "eCAL::UDP::SSenderAttr" is directly included [misc-include-cleaner]

ecal/core/src/logging/config/builder/udp_attribute_builder.cpp:20:

+ #include "io/udp/ecal_udp_sender_attr.h"

github-actions · 2024-12-04T15:24:42Z

ecal/core/src/logging/ecal_log_receiver.cpp

+
+      // serialize message list
+      {
+        const std::lock_guard<std::mutex> lock(m_log_mtx);


warning: no header providing "std::lock_guard" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_receiver.cpp:25:

+ #include <mutex>

github-actions · 2024-12-04T15:24:42Z

ecal/core/src/logging/ecal_log_receiver.cpp

+
+      // serialize message list
+      {
+        const std::lock_guard<std::mutex> lock(m_log_mtx);


warning: no header providing "std::mutex" is directly included [misc-include-cleaner]

const std::lock_guard<std::mutex> lock(m_log_mtx); ^

github-actions · 2024-12-04T15:24:42Z

ecal/core/src/logging/ecal_log_receiver.cpp

+      }
+    }
+
+    bool CLogReceiver::HasSample(const std::string& sample_name_)


warning: method 'HasSample' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/logging/ecal_log_receiver.h:78:

- bool HasSample(const std::string& sample_name_); + static bool HasSample(const std::string& sample_name_);

github-actions · 2024-12-04T15:24:42Z

ecal/core/src/logging/ecal_log_receiver.cpp

+      return (sample_name_ == "_log_message_");
+    }
+
+    bool CLogReceiver::ApplySample(const char* serialized_sample_data_, size_t serialized_sample_size_)


warning: no header providing "size_t" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_receiver.cpp:24:

- #include <iostream> + #include <cstddef> + #include <iostream>

github-actions · 2024-12-04T15:24:42Z

ecal/core/src/logging/ecal_log_receiver.cpp

+    bool CLogReceiver::ApplySample(const char* serialized_sample_data_, size_t serialized_sample_size_)
+    {
+      // TODO: Limit maximum size of collected log messages !
+      Logging::SLogMessage log_message;


warning: no header providing "eCAL::Logging::SLogMessage" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_receiver.cpp:22:

- #include "serialization/ecal_serialize_logging.h" + #include "ecal/types/logging.h" + #include "serialization/ecal_serialize_logging.h"

github-actions

clang-tidy made some suggestions

github-actions · 2024-12-04T16:03:57Z

ecal/core/src/logging/ecal_log_provider.cpp

+  std::string get_time_str()
+  {
+    char            fmt[64];
+    struct timeval  tv;


warning: no header providing "timeval" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_provider.cpp:23:

- #include <ecal/ecal_time.h> + #include <bits/types/struct_timeval.h> + #include <ecal/ecal_time.h>

github-actions · 2024-12-04T16:03:57Z

ecal/core/src/logging/ecal_log_receiver.h

+{
+  namespace Logging
+  {
+    class CLogReceiver


warning: class 'CLogReceiver' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]

class CLogReceiver ^

github-actions · 2024-12-04T16:03:58Z

ecal/core/src/logging/ecal_log_receiver.h

+
+      private:
+        bool HasSample(const std::string& sample_name_);
+        bool ApplySample(const char* serialized_sample_data_, size_t serialized_sample_size_);


warning: no header providing "size_t" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_receiver.h:28:

- #include <ecal/types/logging.h> + #include <cstddef> + #include <ecal/types/logging.h>

github-actions · 2024-12-04T16:03:58Z

ecal/tests/cpp/logging_test/src/logging_test.cpp

@@ -129,7 +130,7 @@ TEST(logging_to /*unused*/, udp /*unused*/)
  const std::string log_message  = "Logging to udp test.";
  auto  ecal_config              = GetUDPConfiguration();

-  eCAL::Initialize(ecal_config, unit_name.c_str(), eCAL::Init::Logging);  
+  eCAL::Initialize(ecal_config, unit_name.c_str(), eCAL::Init::Logging | eCAL::Init::UDPLogReceive);  


warning: no header providing "eCAL::Init::UDPLogReceive" is directly included [misc-include-cleaner]

eCAL::Initialize(ecal_config, unit_name.c_str(), eCAL::Init::Logging | eCAL::Init::UDPLogReceive); ^

KerstinKeller

I think the PR is in a good state. The only thing that I would change is the Config Object.
It feels wrong that the UDP sink has the property receive, I think I would rather split it.

The internal handling could possibly be changed later, also.

ecal/core/include/ecal/config/logging.h

ecal/core/src/config/builder/logging_attribute_builder.cpp

ecal/core/src/logging/config/attributes/ecal_log_provider_attributes.h

KerstinKeller · 2024-12-05T13:21:54Z

ecal/core/src/logging/config/attributes/ecal_log_receiver_attributes.h

+      {
+        std::string address;
+        int         port;
+        bool        broadcast;


Does a receiver need a broadcast argument? I thought it's only relevant for sending infos.

This is because of the eCAL::UDP::SReceiverAttr in io/udp/ , it expects a value also the broadcast value.

github-actions

clang-tidy made some suggestions

github-actions · 2024-12-06T08:41:43Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@ namespace eCAL
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize(0, nullptr, "eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize(0, nullptr, "eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::Default" is directly included [misc-include-cleaner]

app/rec/rec_server_core/src/rec_server_impl.cpp:21:

- #include "recorder_settings.h" + #include "ecal/ecal_init.h" + #include "recorder_settings.h"

github-actions · 2024-12-06T08:41:43Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize(0, nullptr, "eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize(0, nullptr, "eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::Monitoring" is directly included [misc-include-cleaner]

eCAL::Initialize(0, nullptr, "eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive); ^

github-actions · 2024-12-06T08:41:43Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize(0, nullptr, "eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize(0, nullptr, "eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Init::UDPLogReceive" is directly included [misc-include-cleaner]

eCAL::Initialize(0, nullptr, "eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive); ^

github-actions · 2024-12-06T08:41:43Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize(0, nullptr, "eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize(0, nullptr, "eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring | eCAL::Init::UDPLogReceive);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/rec/rec_server_core/src/rec_server_impl.cpp:21:

- #include "recorder_settings.h" + #include "ecal/ecal_core.h" + #include "recorder_settings.h"

github-actions · 2024-12-06T08:41:43Z

ecal/core/src/config/configuration_to_yaml.cpp

@@ -576,6 +576,22 @@ namespace YAML
    /____/\___/\_, /\_, /_/_//_/\_, / 
              /___//___/       /___/  
  */
+
+  Node convert<eCAL::Logging::Sinks::UDPReceiver::Configuration>::encode(const eCAL::Logging::Sinks::UDPReceiver::Configuration& config_)


warning: no header providing "eCAL::Logging::Sinks::UDPReceiver::Configuration" is directly included [misc-include-cleaner]

ecal/core/src/config/configuration_to_yaml.cpp:1:

+ #include "ecal/config/logging.h"

github-actions · 2024-12-06T08:41:44Z

ecal/core/src/config/configuration_to_yaml.h

@@ -297,6 +297,14 @@ namespace YAML
    /____/\___/\_, /\_, /_/_//_/\_, / 
              /___//___/       /___/  
  */
+  template<>
+  struct convert<eCAL::Logging::Sinks::UDPReceiver::Configuration>


warning: no header providing "eCAL::Logging::Sinks::UDPReceiver::Configuration" is directly included [misc-include-cleaner]

ecal/core/src/config/configuration_to_yaml.h:26:

- #include <ecal/config/configuration.h> + #include "ecal/config/logging.h" + #include <ecal/config/configuration.h>

github-actions · 2024-12-06T08:41:44Z

ecal/core/src/logging/config/builder/udp_attribute_builder.cpp

@@ -25,7 +25,7 @@ namespace eCAL
  {
    namespace UDP
    {
-      eCAL::UDP::SSenderAttr ConvertToIOUDPSenderAttributes(const Logging::SUDPSender& sender_attr_)
+      eCAL::UDP::SSenderAttr ConvertToIOUDPSenderAttributes(const Logging::SProviderAttributes::SUDP& sender_attr_)


warning: no header providing "eCAL::Logging::SProviderAttributes" is directly included [misc-include-cleaner]

ecal/core/src/logging/config/builder/udp_attribute_builder.cpp:20:

+ #include "logging/config/attributes/ecal_log_provider_attributes.h"

github-actions · 2024-12-06T08:41:44Z

ecal/core/src/logging/config/builder/udp_attribute_builder.cpp

@@ -25,7 +25,7 @@
  {
    namespace UDP
    {
-      eCAL::UDP::SSenderAttr ConvertToIOUDPSenderAttributes(const Logging::SUDPSender& sender_attr_)
+      eCAL::UDP::SSenderAttr ConvertToIOUDPSenderAttributes(const Logging::SProviderAttributes::SUDP& sender_attr_)


warning: no header providing "eCAL::UDP::SSenderAttr" is directly included [misc-include-cleaner]

ecal/core/src/logging/config/builder/udp_attribute_builder.cpp:20:

+ #include "io/udp/ecal_udp_sender_attr.h"

github-actions · 2024-12-06T08:41:44Z

ecal/core/src/logging/ecal_log_provider.cpp

+
+      const std::string tstring = get_time_str();
+
+      m_logfile_name = m_attributes.file_config.path + tstring + "_" + m_attributes.unit_name + "_" + std::to_string(m_attributes.process_id) + ".log";


warning: no header providing "std::to_string" is directly included [misc-include-cleaner]

m_logfile_name = m_attributes.file_config.path + tstring + "_" + m_attributes.unit_name + "_" + std::to_string(m_attributes.process_id) + ".log"; ^

github-actions · 2024-12-06T08:41:44Z

ecal/core/src/logging/ecal_log_provider.cpp

+
+    bool CLogProvider::StartUDPLogging()
+    {
+      const eCAL::UDP::SSenderAttr attr = Logging::UDP::ConvertToIOUDPSenderAttributes(m_attributes.udp_config);


warning: no header providing "eCAL::UDP::SSenderAttr" is directly included [misc-include-cleaner]

ecal/core/src/logging/ecal_log_provider.cpp:20:

- #include "serialization/ecal_serialize_logging.h" + #include "io/udp/ecal_udp_sender_attr.h" + #include "serialization/ecal_serialize_logging.h"

github-actions

clang-tidy made some suggestions

github-actions · 2024-12-06T13:26:26Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@ namespace eCAL
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize("", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize("eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Init::Default" is directly included [misc-include-cleaner]

app/rec/rec_server_core/src/rec_server_impl.cpp:21:

- #include "recorder_settings.h" + #include "ecal/ecal_init.h" + #include "recorder_settings.h"

github-actions · 2024-12-06T13:26:26Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize("", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize("eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Init::Monitoring" is directly included [misc-include-cleaner]

eCAL::Initialize("eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring); ^

github-actions · 2024-12-06T13:26:26Z

app/rec/rec_server_core/src/rec_server_impl.cpp

@@ -60,7 +60,7 @@
      settings_.ClearHostFilter(); // There is no global host filter

      // Initialize eCAL
-      eCAL::Initialize("", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize("eCALRec-Server", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/rec/rec_server_core/src/rec_server_impl.cpp:21:

- #include "recorder_settings.h" + #include "ecal/ecal_core.h" + #include "recorder_settings.h"

github-actions · 2024-12-06T13:26:27Z

ecal/core/include/ecal/config/logging.h

-          std::string         path            { "" };                //!< Path to log file (Default: "")
-          eCAL_Logging_Filter filter_log_file { log_level_none };    /*!< Log messages logged into file system (all, info, warning, error, fatal, debug1, debug2, debug3, debug4)
-                                                                          (Default: info, warning, error, fatal)*/
+          std::string path { "" };                      //!< Path to log file (Default: "")


warning: redundant string initialization [readability-redundant-string-init]

Suggested change

std::string path { "" }; //!< Path to log file (Default: "")

std::string path; //!< Path to log file (Default: "")

github-actions · 2024-12-06T13:26:27Z

ecal/core/src/config/configuration_to_yaml.cpp

-  
-  Node convert<eCAL::Logging::Sinks::UDP::Configuration>::encode(const eCAL::Logging::Sinks::UDP::Configuration& config_)
+
+  Node convert<eCAL::Logging::Sinks::UDP::ReceiverConfiguration>::encode(const eCAL::Logging::Sinks::UDP::ReceiverConfiguration& config_)


warning: no header providing "eCAL::Logging::Sinks::UDP::ReceiverConfiguration" is directly included [misc-include-cleaner]

ecal/core/src/config/configuration_to_yaml.cpp:1:

+ #include "ecal/config/logging.h"

github-actions · 2024-12-06T13:26:27Z

ecal/core/src/config/configuration_to_yaml.h

@@ -298,19 +298,19 @@ namespace YAML
              /___//___/       /___/  
  */
  template<>
-  struct convert<eCAL::Logging::Sinks::UDP::Configuration>
+  struct convert<eCAL::Logging::Sinks::UDP::ReceiverConfiguration>


warning: no header providing "eCAL::Logging::Sinks::UDP::ReceiverConfiguration" is directly included [misc-include-cleaner]

ecal/core/src/config/configuration_to_yaml.h:26:

- #include <ecal/config/configuration.h> + #include "ecal/config/logging.h" + #include <ecal/config/configuration.h>

github-actions · 2024-12-06T13:26:27Z

ecal/core/src/config/configuration_to_yaml.h

  };

  template<>
-  struct convert<eCAL::Logging::Sinks::Console::Configuration>
+  struct convert<eCAL::Logging::Sinks::UDP::ProviderConfiguration>


warning: no header providing "eCAL::Logging::Sinks::UDP::ProviderConfiguration" is directly included [misc-include-cleaner]

struct convert<eCAL::Logging::Sinks::UDP::ProviderConfiguration> ^

github-actions · 2024-12-06T13:26:27Z

ecal/core/src/config/configuration_to_yaml.h

@@ -321,6 +321,22 @@
    static bool decode(const Node& node_, eCAL::Logging::Sinks::File::Configuration& config_);
  };

+  template<>
+  struct convert<eCAL::Logging::Sinks::UDP::Configuration>


warning: no header providing "eCAL::Logging::Sinks::UDP::Configuration" is directly included [misc-include-cleaner]

struct convert<eCAL::Logging::Sinks::UDP::Configuration> ^

github-actions · 2024-12-06T13:26:28Z

ecal/core/src/config/configuration_to_yaml.h

+  };
+
+  template<>
+  struct convert<eCAL::Logging::Sinks::Sink>


warning: no header providing "eCAL::Logging::Sinks::Sink" is directly included [misc-include-cleaner]

struct convert<eCAL::Logging::Sinks::Sink> ^

github-actions · 2024-12-06T13:26:28Z

ecal/core/src/config/ecal_config.cpp

-    eCAL_Logging_Filter GetConsoleLogFilter                () { return GetConfiguration().logging.sinks.console.filter_log_con; }
-    eCAL_Logging_Filter GetFileLogFilter                   () { return GetConfiguration().logging.sinks.file.filter_log_file; }
-    eCAL_Logging_Filter GetUdpLogFilter                    () { return GetConfiguration().logging.sinks.udp.filter_log_udp; }
+    eCAL_Logging_Filter GetConsoleLogFilter                () { return GetConfiguration().logging.sinks.console.filter_log; }


warning: no header providing "eCAL_Logging_Filter" is directly included [misc-include-cleaner]

ecal/core/src/config/ecal_config.cpp:19:

- #include <ecal/ecal_config.h> + #include "ecal/ecal_log_level.h" + #include <ecal/ecal_config.h>

KerstinKeller

I just have a very few minor remarks, but I guess then finally ready to be merged 😄

KerstinKeller · 2024-12-06T14:12:50Z

ecal/core/include/ecal/config/logging.h

+
+        File::Configuration file_config;
+        UDP::Configuration  udp_config;
+


Looks very clean like this!

KerstinKeller · 2024-12-06T14:13:34Z

ecal/core/include/ecal/ecal_init.h

+    static const unsigned int Service       =    0x004;
+    static const unsigned int Monitoring    =    0x008;
+    static const unsigned int Logging       =    0x010;
+    static const unsigned int TimeSync      =    0x020;


you could realign, so you don't get any changes in this file

KerstinKeller · 2024-12-06T14:21:15Z

ecal/core/src/config/configuration_to_yaml.h


-    static bool decode(const Node& node_, eCAL::Logging::Sinks::UDP::Configuration& config_);
+    static bool decode(const Node& node_, eCAL::Logging::Sinks::UDP::ReceiverConfiguration& config_);


It feels a bit strange that ReceiverConfiguration is in the Sinks namespace.
Does eCAL::Logging::Receiver::UDP::Configuration make more sense?

github-actions

clang-tidy made some suggestions

github-actions · 2024-12-06T16:30:10Z

ecal/core/src/config/configuration_to_yaml.cpp

-  
-  Node convert<eCAL::Logging::Sinks::UDP::Configuration>::encode(const eCAL::Logging::Sinks::UDP::Configuration& config_)
+
+  Node convert<eCAL::Logging::Receiver::UDP::Configuration>::encode(const eCAL::Logging::Receiver::UDP::Configuration& config_)


warning: no header providing "eCAL::Logging::Receiver::UDP::Configuration" is directly included [misc-include-cleaner]

ecal/core/src/config/configuration_to_yaml.cpp:1:

+ #include "ecal/config/logging.h"

github-actions · 2024-12-06T16:30:11Z

ecal/core/src/config/configuration_to_yaml.cpp

-    std::vector<std::string> tmp;
-    AssignValue<std::vector<std::string>>(tmp, node_, "level");
-    config_.filter_log_udp = ParseLogLevel(tmp);
+  Node convert<eCAL::Logging::Receiver::Configuration>::encode(const eCAL::Logging::Receiver::Configuration& config_)


warning: no header providing "eCAL::Logging::Receiver::Configuration" is directly included [misc-include-cleaner]

Node convert<eCAL::Logging::Receiver::Configuration>::encode(const eCAL::Logging::Receiver::Configuration& config_) ^

github-actions · 2024-12-06T16:30:11Z

ecal/core/src/config/configuration_to_yaml.cpp

    return true;
  }

-  Node convert<eCAL::Logging::Sinks::Console::Configuration>::encode(const eCAL::Logging::Sinks::Console::Configuration& config_)
+  Node convert<eCAL::Logging::Provider::UDP::Configuration>::encode(const eCAL::Logging::Provider::UDP::Configuration& config_)


warning: no header providing "eCAL::Logging::Provider::UDP::Configuration" is directly included [misc-include-cleaner]

Node convert<eCAL::Logging::Provider::UDP::Configuration>::encode(const eCAL::Logging::Provider::UDP::Configuration& config_) ^

github-actions · 2024-12-06T16:30:11Z

ecal/core/src/config/configuration_to_yaml.cpp

+    return true;
+  }
+
+  Node convert<eCAL::Logging::Provider::Sink>::encode(const eCAL::Logging::Provider::Sink& config_)


warning: no header providing "eCAL::Logging::Provider::Sink" is directly included [misc-include-cleaner]

Node convert<eCAL::Logging::Provider::Sink>::encode(const eCAL::Logging::Provider::Sink& config_) ^

github-actions · 2024-12-06T16:30:11Z

ecal/core/src/config/configuration_to_yaml.cpp

    return true;
  }

-  Node convert<eCAL::Logging::Sinks::File::Configuration>::encode(const eCAL::Logging::Sinks::File::Configuration& config_)
+  Node convert<eCAL::Logging::Provider::File::Configuration>::encode(const eCAL::Logging::Provider::File::Configuration& config_)


warning: no header providing "eCAL::Logging::Provider::File::Configuration" is directly included [misc-include-cleaner]

Node convert<eCAL::Logging::Provider::File::Configuration>::encode(const eCAL::Logging::Provider::File::Configuration& config_) ^

github-actions · 2024-12-06T16:30:11Z

ecal/core/src/config/configuration_to_yaml.h

  };

  template<>
-  struct convert<eCAL::Logging::Sinks::File::Configuration>
+  struct convert<eCAL::Logging::Provider::File::Configuration>


warning: no header providing "eCAL::Logging::Provider::File::Configuration" is directly included [misc-include-cleaner]

struct convert<eCAL::Logging::Provider::File::Configuration> ^

github-actions · 2024-12-06T16:30:11Z

ecal/core/src/config/configuration_to_yaml.h

  };

  template<>
-  struct convert<eCAL::Logging::Sinks::Configuration>
+  struct convert<eCAL::Logging::Provider::UDP::Configuration>


warning: no header providing "eCAL::Logging::Provider::UDP::Configuration" is directly included [misc-include-cleaner]

struct convert<eCAL::Logging::Provider::UDP::Configuration> ^

github-actions · 2024-12-06T16:30:11Z

ecal/core/src/config/configuration_to_yaml.h

+  };
+
+  template<>
+  struct convert<eCAL::Logging::Provider::Sink>


warning: no header providing "eCAL::Logging::Provider::Sink" is directly included [misc-include-cleaner]

struct convert<eCAL::Logging::Provider::Sink> ^

github-actions · 2024-12-06T16:30:12Z

ecal/core/src/config/configuration_to_yaml.h

+  };
+
+  template<>
+  struct convert<eCAL::Logging::Provider::Configuration>


warning: no header providing "eCAL::Logging::Provider::Configuration" is directly included [misc-include-cleaner]

struct convert<eCAL::Logging::Provider::Configuration> ^

github-actions · 2024-12-06T16:30:12Z

ecal/core/src/config/ecal_config.cpp

-    eCAL_Logging_Filter GetConsoleLogFilter                () { return GetConfiguration().logging.sinks.console.filter_log_con; }
-    eCAL_Logging_Filter GetFileLogFilter                   () { return GetConfiguration().logging.sinks.file.filter_log_file; }
-    eCAL_Logging_Filter GetUdpLogFilter                    () { return GetConfiguration().logging.sinks.udp.filter_log_udp; }
+    eCAL_Logging_Filter GetConsoleLogFilter                () { return GetConfiguration().logging.provider.console.filter_log; }


warning: no header providing "eCAL_Logging_Filter" is directly included [misc-include-cleaner]

ecal/core/src/config/ecal_config.cpp:19:

- #include <ecal/ecal_config.h> + #include "ecal/ecal_log_level.h" + #include <ecal/ecal_config.h>

KerstinKeller reviewed Dec 2, 2024

View reviewed changes

Peguen changed the title ~~[Logging] Introducing Provider/Receiver pattern for lagging~~ [Logging] Introducing Provider/Receiver pattern for logging Dec 2, 2024

github-actions bot reviewed Dec 2, 2024

View reviewed changes

Peguen added the cherry-pick-to-NONE Don't cherry-pick these changes label Dec 2, 2024

github-actions bot reviewed Dec 3, 2024

View reviewed changes

github-actions bot reviewed Dec 4, 2024

View reviewed changes

Peguen marked this pull request as ready for review December 4, 2024 16:02

github-actions bot reviewed Dec 4, 2024

View reviewed changes

Peguen added 16 commits December 5, 2024 09:49

Changed pubsub logging to use the API instead of globals.

dbb5478

Split of ecal_log into log provider and receiver.

9cbaf5a

Added missing atomic header.

bddd31f

Changed typo in includes.

360deb9

Introduced logging UDP receive variable.

28d7734

Receive functionality in log_receiver.

2c2956c

Adapted logging tests.

24a0b13

Removed unused attributes for loggin receiver/provider.

50f88ca

Changed logging structs to be defined within the attribute struct.

294e531

Changed global accessor handling.

a5bf465

Added UDPLogReceive to eCAL::Init.

c390e4c

Added UDPLogReceive to Init::ALL.

d22b9a9

Added UDPLogReceive to apps.

960e9ba

Small clangtidy things.

546db2c

Adapted test for logging.

4072334

Removed failing header.

ee26111

Peguen force-pushed the feature/logging_split branch from 7c3cfe5 to ee26111 Compare December 5, 2024 08:54

Fixed wrong type in default yaml configuration.

bcf6d54

KerstinKeller reviewed Dec 5, 2024

View reviewed changes

Better logic for logging attributes.

c4f4cd7

Peguen added 2 commits December 6, 2024 09:11

Changed udp logging config to have an own udp receiving configuration.

e0729f6

Merge branch 'master' into feature/logging_split

2d6cee1

github-actions bot reviewed Dec 6, 2024

View reviewed changes

Peguen and others added 3 commits December 6, 2024 13:47

Changed logging struct and yaml to be consistent with the attributes.

2b4d197

Merge remote.

2c53961

Merge branch 'master' into feature/logging_split

9ceee76

github-actions bot reviewed Dec 6, 2024

View reviewed changes

KerstinKeller reviewed Dec 6, 2024

View reviewed changes

Reworked logging structure.

76707d5

github-actions bot reviewed Dec 6, 2024

View reviewed changes

KerstinKeller approved these changes Dec 6, 2024

View reviewed changes

Peguen merged commit 7ba8e0a into master Dec 9, 2024
20 checks passed

Peguen deleted the feature/logging_split branch December 9, 2024 10:22


		const std::string tstring = get_time_str();

		m_logfile_name = m_attributes.file_config.path + tstring + "_" + m_attributes.unit_name + "_" + std::to_string(m_attributes.process_id) + ".log";

	std::string path { "" }; //!< Path to log file (Default: "")
	std::string path; //!< Path to log file (Default: "")


		Node convert<eCAL::Logging::Sinks::UDP::Configuration>::encode(const eCAL::Logging::Sinks::UDP::Configuration& config_)

		Node convert<eCAL::Logging::Sinks::UDP::ReceiverConfiguration>::encode(const eCAL::Logging::Sinks::UDP::ReceiverConfiguration& config_)


		File::Configuration file_config;
		UDP::Configuration udp_config;


		static bool decode(const Node& node_, eCAL::Logging::Sinks::UDP::Configuration& config_);
		static bool decode(const Node& node_, eCAL::Logging::Sinks::UDP::ReceiverConfiguration& config_);


		Node convert<eCAL::Logging::Sinks::UDP::Configuration>::encode(const eCAL::Logging::Sinks::UDP::Configuration& config_)

		Node convert<eCAL::Logging::Receiver::UDP::Configuration>::encode(const eCAL::Logging::Receiver::UDP::Configuration& config_)

[Logging] Introducing Provider/Receiver pattern for logging #1831

[Logging] Introducing Provider/Receiver pattern for logging #1831

Conversation

Peguen commented Dec 2, 2024 • edited Loading

Description

KerstinKeller left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 4, 2024

Peguen commented Dec 2, 2024 •

edited

Loading