Use uint64_t for topic id in hdf5 #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
contrib/ecalhdf5/src/hdf5_helper.h
Outdated
| @@ -54,8 +73,7 @@ inline std::string printHex(eCAL::experimental::measurement::base::Channel::id_t | |||
|
|
|||
| inline eCAL::experimental::measurement::base::Channel::id_t parseHexID(std::string string_id) | |||
| { | |||
| auto unsigned_value = std::stoull(string_id, 0, 16); | |||
| return static_cast<eCAL::experimental::measurement::base::Channel::id_t>(unsigned_value); | |||
| return std::stoull(string_id, 0, 16); | |||
There was a problem hiding this comment.
warning: use nullptr [modernize-use-nullptr]
Suggested change
| return std::stoull(string_id, 0, 16); | |
| return std::stoull(string_id, nullptr, 16); |
| @@ -68,7 +68,7 @@ namespace eCAL | |||
|
|
|||
| struct Channel | |||
| { | |||
| using id_t = std::int64_t; | |||
| using id_t = std::uint64_t; | |||
|
|
|||
| std::string name = ""; | |||
There was a problem hiding this comment.
warning: no type named 'string' in namespace 'std' [clang-diagnostic-error]
std::string name = "";
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the underlying type of the topic ID (there is no reason for IDs to be of a signed type).
Also add missing license headers.