[core] SetExclFilter, SetInclFilter, SetFilterState removed from monitoring API #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| include_string = QString::fromStdString(eCAL::Config::GetMonitoringFilterIncludeList()); //ini.GetValue(MON_SECTION_S, MON_FILTER_INCL_S); | ||
|
|
||
| // this is now just taken from the old ecal.yaml/ini configuration | ||
| QString exclude_string{ "^__.*$" }; //!< Topics blacklist as regular expression (will not be monitored) (Default: "^__.*$") |
There was a problem hiding this comment.
warning: variable 'exclude_string' of type 'QString' can be declared 'const' [misc-const-correctness]
Suggested change
| QString exclude_string{ "^__.*$" }; //!< Topics blacklist as regular expression (will not be monitored) (Default: "^__.*$") | |
| QString const exclude_string{ "^__.*$" }; //!< Topics blacklist as regular expression (will not be monitored) (Default: "^__.*$") |
|
|
||
| // this is now just taken from the old ecal.yaml/ini configuration | ||
| QString exclude_string{ "^__.*$" }; //!< Topics blacklist as regular expression (will not be monitored) (Default: "^__.*$") | ||
| QString include_string{ "" }; //!< Topics whitelist as regular expression (will be monitored only) (Default: "") |
There was a problem hiding this comment.
warning: variable 'include_string' of type 'QString' can be declared 'const' [misc-const-correctness]
Suggested change
| QString include_string{ "" }; //!< Topics whitelist as regular expression (will be monitored only) (Default: "") | |
| QString const include_string{ "" }; //!< Topics whitelist as regular expression (will be monitored only) (Default: "") |
KerstinKeller
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3 monitoring API functions
SetExclFilter, SetInclFilter, SetFilterStateremoved from API. Tests removed, YAML configuration adapted.TODO: eCALMon GUI now uses fixed include and exclude regex expressions. Needs to be configured another way in future versions.