Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer Type is wrongly resolved during dataplane self registration #4686

Open
rafaelmag110 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #4687
Open

Transfer Type is wrongly resolved during dataplane self registration #4686

rafaelmag110 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #4687
Assignees
Labels
triage all new issues awaiting classification

Comments

@rafaelmag110
Copy link
Contributor

rafaelmag110 commented Dec 19, 2024

Bug Report

Describe the Bug

With the bi-directional transfer feature, a set of supported responseTypes was introduced in the public endpoint generation service. These supported responses types are concatened to the overall supported transferTypes of the dataplane.

Since the feature was initially proposed with the transfer types to be HttpData-PULL/Websocket, but then changed to HttpData-PULL-Websocket, some reminiscences of the first proposal where not removed.

The self registration extensions tests didn't caught this because no response types where added to the tests and "publicEndpointGeneratorService.supportedResponseTypes()" returns an empty set, so the tests worked fine.

Expected Behavior

When there are supported response types, the dataplane self registration extension should advertise to the control plane in the correct format (e.g. HttpData-PULL-Websocket)

@github-actions github-actions bot added the triage all new issues awaiting classification label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage all new issues awaiting classification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant