Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transfer type resolution on dp self registration #4687

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rafaelmag110
Copy link
Contributor

@rafaelmag110 rafaelmag110 commented Dec 19, 2024

What this PR changes/adds

The responseType is now concatenated to the transferType as expected.

Why it does that

It was not being correctly concatenated.

Further notes

Also fixed some code docs lying around that had "HttpData-PULL/Websocket"

Linked Issue(s)

Closes #4686

@rafaelmag110
Copy link
Contributor Author

@paullatzelsperger as reviewer as well since he implemented the bi-directional channel feature.

@ndr-brt ndr-brt added the bug Something isn't working label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer Type is wrongly resolved during dataplane self registration
2 participants