Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): speed up management test #4223

Merged
merged 1 commit into from
May 30, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 29, 2024

What this PR changes/adds

Speed up management-api end to end test by using a single runtime for class.

Why it does that

ci

Further notes

  • switched the test design from abstraction to composition leveraging the junit extension model, now we have 2 extensions: InMemory and Postgres, they take care of initializing the runtime with the correct configuration. This avoided statically defined configurations, and every test execution will have their own port config (this opens up the possibility to leverage the parallel execution of gradle, not applied in this PR)

Linked Issue(s)

Closes #4222

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added refactoring Cleaning up code and dependencies build Anything related to the CI/CD Pipeline on Github Actions labels May 29, 2024
@jimmarino
Copy link
Contributor

🚀

@jimmarino jimmarino self-requested a review May 30, 2024 07:21
@ndr-brt ndr-brt merged commit d22b18e into eclipse-edc:main May 30, 2024
17 of 19 checks passed
@ndr-brt ndr-brt deleted the speed-up-management-tests branch May 30, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Anything related to the CI/CD Pipeline on Github Actions refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up End to End test
3 participants