-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(test): speed up e2e tests #4302
Conversation
core/common/junit/src/main/java/org/eclipse/edc/junit/extensions/ClasspathReader.java
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4302 +/- ##
==========================================
+ Coverage 71.74% 75.16% +3.42%
==========================================
Files 919 1052 +133
Lines 18457 21094 +2637
Branches 1037 1180 +143
==========================================
+ Hits 13242 15856 +2614
+ Misses 4756 4724 -32
- Partials 459 514 +55 ☔ View full report in Codecov by Sentry. |
i'm wondering: the improvement consists of not doing the CP scanning in the |
the advantage kicks in also in the "runtime per class" case, e.g. in the "e2e transfer tests" where a single runtime is used multiple time across different tests (see |
true. seriously cool shit!! |
What this PR changes/adds
Export classpath loading from
EmbeddedRuntime
Why it does that
Classpath loading is a time consuming operation (approx 14 seconds first time it runs, 4-5 seconds other times) as it needs to invoke gradle wrapper and the
printClasspath
task. By doing it just once for every runtime in thee2e-transfer-test
makes tests run faster (approx 1 minute less than before)Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.