refactor: TokenGenerationService takes key ID instead of PrivateKey #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4395 +/- ##
==========================================
+ Coverage 71.74% 74.94% +3.20%
==========================================
Files 919 1072 +153
Lines 18457 21455 +2998
Branches 1037 1172 +135
==========================================
+ Hits 13242 16080 +2838
- Misses 4756 4852 +96
- Partials 459 523 +64 ☔ View full report in Codecov by Sentry. |
paullatzelsperger
requested review from
bscholtes1A and
jimmarino
as code owners
paullatzelsperger
force-pushed
the
refactor/tokengenerator_service
branch
from
bd06217 to
bc239d1
Compare
wolf4ood
approved these changes
Aug 7, 2024
spi/common/jwt-signer-spi/src/main/java/org/eclipse/edc/jwt/signer/spi/JwsSignerProvider.java
Outdated
Show resolved
Hide resolved
…gner/spi/JwsSignerProvider.java Co-authored-by: Enrico Risa <enrico.risa@gmail.com>
ndr-brt
reviewed
Aug 7, 2024
core/common/token-core/src/main/java/org/eclipse/edc/token/JwtGenerationService.java
Outdated
Show resolved
Hide resolved
spi/common/jwt-signer-spi/src/main/java/org/eclipse/edc/jwt/signer/spi/JwsSignerProvider.java
Outdated
Show resolved
Hide resolved
spi/common/jwt-signer-spi/src/main/java/org/eclipse/edc/jwt/signer/spi/JwsSignerProvider.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/edc/iam/identitytrust/sts/defaults/StsClientTokenIssuanceIntegrationTest.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/edc/iam/identitytrust/sts/defaults/StsClientTokenIssuanceIntegrationTest.java
Outdated
Show resolved
Hide resolved
…GenerationService.java Co-authored-by: ndr_brt <andrea.bertagnolli@gmail.com>
paullatzelsperger
force-pushed
the
refactor/tokengenerator_service
branch
from
1820248 to
b76fcf0
Compare
paullatzelsperger
force-pushed
the
refactor/tokengenerator_service
branch
2 times, most recently
from
c670e3f to
90600fd
Compare
paullatzelsperger
force-pushed
the
refactor/tokengenerator_service
branch
from
90600fd to
70570fb
Compare
ndr-brt
approved these changes
Aug 8, 2024
Comment on lines
+76
to
+77
| client -> new JwtGenerationService(keyId -> privateKeyResolver.resolvePrivateKey(keyId) | ||
| .compose(pk -> Result.ofThrowable(() -> CryptoConverter.createSignerFor(pk)))), |
There was a problem hiding this comment.
this is the same as the one instantiated in the TokenServicesExtension, it could be extracted in a separate class to avoid the duplication
There was a problem hiding this comment.
ah, clicked "merge" too fast. will do this in another PR down the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Refactors the
TokenGenerationServiceto take aprivateKeyIdinstead of aSupplier<PrivateKey>. In addition, a new interfaceJwsSignerProviderwas added, that can be used to plug in customJWSSignerimplementations.If no custom impl is provided, a default
JWSSigneris created, that resolves the private key from the vault, same as now.Why it does that
Being able to contribute a custom JWSSigner is a precondition for having tokens signed by a remote service, such as a HSM
Further notes
Do not review yet - this is just a PoC!
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.