Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dedicated class for default JwsSignerProvider #4403

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

provide a dedicated class for the default JwsSignerProvider

Why it does that

avoid code duplication

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Aug 9, 2024
@paullatzelsperger paullatzelsperger force-pushed the chore/provide_dedicated_class_for_default_jwssignerprovider branch from 0be4abb to 823f5a9 Compare August 9, 2024 07:55
@paullatzelsperger paullatzelsperger force-pushed the chore/provide_dedicated_class_for_default_jwssignerprovider branch from 823f5a9 to b93e15b Compare August 9, 2024 07:56
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.96%. Comparing base (7f20ba5) to head (b93e15b).
Report is 428 commits behind head on main.

Files with missing lines Patch % Lines
...c/security/token/jwt/DefaultJwsSignerProvider.java 0.00% 5 Missing ⚠️
.../org/eclipse/edc/token/TokenServicesExtension.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4403      +/-   ##
==========================================
+ Coverage   71.74%   74.96%   +3.21%     
==========================================
  Files         919     1073     +154     
  Lines       18457    21459    +3002     
  Branches     1037     1171     +134     
==========================================
+ Hits        13242    16086    +2844     
- Misses       4756     4852      +96     
- Partials      459      521      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit b07d977 into eclipse-edc:main Aug 9, 2024
23 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/provide_dedicated_class_for_default_jwssignerprovider branch August 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants